Comment 18 for bug 1068154

Matt Riedemann (mriedem) wrote :

Melanie Witt also makes good points in the old review

melanie witt
May 5, 2015

Patch Set 5: Code-Review-1

The weird thing about this is, it allows one to update the "hostname" of the instance before it is actually using that hostname (and may potentially never use it, if it is never rebuilt). I was also concerned whether the guest will actually consume the hostname from metadata again when rebuilt. I assume from your patch that it does, since virt domain is destroyed and recreated during a rebuild.

Also mentioned in the bug report, what about updating in dnsmasq? Point being, I don't think updating the hostname is as simple and would take more work to change it in the db, make the guest take the new name (without a rebuild or anything), update it in dnsmasq, etc.


So I think this is definitely a bigger API change and would require a spec to consider the impact of a change in behavior like this.

See for submitting a spec.