| 2012-09-03 09:53:50 |
Ian Wells |
description |
network/model.py converts new-style models to old ones.
When it's trying to identify the IP address of a DHCP server, it uses the DHCP server address, if set, and the gateway if not.
There's no documentation of this functionality in the code, so I don't know why it's there. However, I believe the DHCP server address should always be set to the correct address and, if it's unset, then there is no DHCP server - so the fallback should be removed from the code. (I'd appreciate someone confirming that.)
This bug will affect the libvirt driver (which at present uses legacy()-style models) and anything that uses virt/firewall.py (which converts new models to legacy form). |
network/model.py converts new-style models to old ones.
When it's trying to identify the IP address of a DHCP server, it uses the DHCP server address, if set, and the gateway if not. DHCP filtering is only turned off completely (i.e. all DHCP packets are denied) if neither a DHCP server nor a gateway are set.
There's no documentation of this functionality in the code, so I don't know why it's there. However, I believe the DHCP server address should always be set to the correct address and, if it's unset, then there is no DHCP server - so the fallback should be removed from the code. (I'd appreciate someone confirming that.)
This bug will affect the libvirt driver (which at present uses legacy()-style models) and anything that uses virt/firewall.py (which converts new models to legacy form). |
|
