nova/virt/disk/api.py imports crypt, doesn't work on Windows

[Alessandro Pilotti]

At line 28:

import crypt

breaks Windows compatibility.

The crypt module is used only in _set_passwd (line 498).

I'd suggest to move the import there or to do a conditional import, like in the attached diff.

[Russell Bryant (russellb)]

It looks like the usage of crypt is pretty basic. We should be able to change to something else that is compatible.

[Alessandro Pilotti (alexpilotti)]

In the meantime, can we just commit the simple os based fix proposed in the previous comment?

It's a blocking issue for nova compute on Windows.

Thanks

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12939

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12939
Committed: http://github.com/openstack/nova/commit/918a02d5cc3c845bcd58e00fcdf2728e78dafa26
Submitter: Jenkins
Branch: master

commit 918a02d5cc3c845bcd58e00fcdf2728e78dafa26
Author: Alessandro Pilotti <email address hidden>
Date: Thu Sep 13 15:08:45 2012 +0300

    Fixes import issue on Windows

    Fixes Bug #1034043

    The crypt module is not available on Windows.
    Since this is a blocking issue on Hyper-V and since the only
    function using it is _set_passwd (not implemented on Windows),
    the import can be safely conditionally avoided.

    Change-Id: Iefe97edcfcff3b70593e07628b6a6f85e680cbc7