attach volume fails with n-vol using iscsi since 1ba3dfec

Bug #1033670 reported by Renuka Apte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Renuka Apte

Bug Description

Not sure if this is only with xenapi

The change to add persistent volumes for tgtd (https://review.openstack.org/#/c/10414/2) passes parameters as '--conf %s' % volume_path, '--update %s' % vol_id etc. which cause the tgt-admin command to fail silently because the options are misquoted.

Instead pass as '--conf', '%s' % volume_path

Renuka Apte (renukaapte)
Changed in nova:
assignee: nobody → Renuka Apte (renukaapte)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/10920

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/10920
Committed: http://github.com/openstack/nova/commit/3222ba2728dbf1d0760c5dbe0c8b77c73936ee80
Submitter: Jenkins
Branch: master

commit 3222ba2728dbf1d0760c5dbe0c8b77c73936ee80
Author: Renuka Apte <email address hidden>
Date: Mon Aug 6 14:27:30 2012 -0700

    Fixes parameter passing to tgt-admin for iscsi

    Fixes bug 1033670

    The change to add persistent volumes for tgtd 1ba3dfec,
    passes parameters as '--conf %s' % volume_path,
    '--update %s' % vol_id etc. which cause the tgt-admin command
    to fail silently because the options are misquoted.

    Instead pass as '--conf', volume_path

    Change-Id: Ic986ee5fe21a0927c1aa2f8c94420fe30127d088

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.