SADeprecationWarning: Pool.add_listener is deprecated. Use event.listen()

[Johannes Erdfelt]

The listeners kwarg has been deprecated in SQLAlchemy 0.7. The replacement is the new event.listen() API.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10606

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/10606
Committed: http://github.com/openstack/nova/commit/28a7ac658959a8dcc8ba0b7d316fe598e7992c8b
Submitter: Jenkins
Branch: master

commit 28a7ac658959a8dcc8ba0b7d316fe598e7992c8b
Author: Johannes Erdfelt <email address hidden>
Date: Tue Jul 31 15:32:08 2012 +0000

    Use event.listen() instead of deprecated listeners kwarg

    Fixes bug 1031405

    The listeners kwarg is deprecated in SQLAlchemy 0.7.0. Since 0.7.3 is
    the minimum required version of SQLAlchemy, use the new event.listen()
    API instead.

    Change-Id: I3d2bd2e65dbc6787d1c9b69ffd0bcff85c157869

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10665

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/10665
Committed: http://github.com/openstack/glance/commit/6cc23005d042901e01bfee4deeb6367879012d22
Submitter: Jenkins
Branch: master

commit 6cc23005d042901e01bfee4deeb6367879012d22
Author: Josh Kearney <email address hidden>
Date: Wed Aug 1 12:05:42 2012 -0500

    Use event.listen() instead of deprecated listeners kwarg.

    The listeners kwarg is deprecated in SQLAlchemy 0.7.0. Since 0.7.3 is
    the minimum required version of SQLAlchemy, use the new event.listen()
    API instead.

    Fixes bug 1031405.

    Change-Id: Ibbfe46d065575b1954a47b3a28c61151dfb1e06e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10746

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/10862

[Brian Waldon (bcwaldon)]

Not backporting to glance 2012.1.2 since this is only a deprecation warning.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/11644

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/11644
Committed: http://github.com/openstack/cinder/commit/5da61a7ad9d7c3320831c437c03c428b9df84ebb
Submitter: Jenkins
Branch: master

commit 5da61a7ad9d7c3320831c437c03c428b9df84ebb
Author: unicell <email address hidden>
Date: Mon Aug 20 19:34:19 2012 +0800

    Use event.listen() instead of deprecated listeners kwarg

    Fixes bug 1031405

    The listeners kwarg is deprecated in SQLAlchemy 0.7.0. Since 0.7.3 is
    the minimum required version of SQLAlchemy, use the new event.listen()
    API instead.

    Change-Id: I1b851e197c04b131ae96e814780b04e6dcdeeb1a

[Dolph Mathews (dolph)]

Patch to keystone was abandoned.

[Anthony Dodd (thedodd)]

I would like to get started on addressing this issue in keystone, but I'm not quite sure where to begin.

[Johannes Erdfelt (johannes.erdfelt)]

You would do pretty much the same thing all of the other projects have done. You can use this patch for nova as an example:

https://review.openstack.org/10606

[Dolph Mathews (dolph)]

In keystone, the listeners kwarg is constructed here:

https://github.com/openstack/keystone/blob/cdc0ee1f85aa762f7d34297a034a10519ba9f40f/keystone/common/sql/core.py#L243

[Anthony Dodd (thedodd)]

Great, thanks gentlemen. I will do the necessary research and, hopefully, have a fixed bug shortly!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/34266

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/34266
Committed: http://github.com/openstack/keystone/commit/05e7a87b893aae0cb22ef85e282ada4979f9db9e
Submitter: Jenkins
Branch: master

commit 05e7a87b893aae0cb22ef85e282ada4979f9db9e
Author: Anthony Dodd <email address hidden>
Date: Mon Jun 24 16:23:00 2013 -0500

    Use event.listen() instead of deprecated listeners kwarg

    The listeners kwarg is deprecated in SQLAlchemy 0.7.0.
    Use the new event.listen() method instead.

    Instead of using the original approach of testing whether or not the string
    'mysql' is in 'connection_dict.drivername', now we are using a more direct
    string equality test to ensure that engine.name == 'mysql' before passing
    it to sql.event.listen().

    We've decided to change the name of our ping_listener function to reflect its
    purpose more accurately. Its name has been changed from "ping_listener" to
    "mysql_on_checkout".

    Change-Id: Ib9ef52404e3d474a60cdc82e8fcf8c6a9616bce3
    Fixes: bug #1031405