Port-id should be specified for each nic

Bug #1031096 reported by Nachi Ueno
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Nachi Ueno

Bug Description

The idea is that we don't want people to have to pass all possible quantum port attributes (IPs, security groups, etc.) in through nova. So instead, if they want something other than a "default" port, a tenant (or code acting on behalf of the tenant) would create a port with those settings and pass it to Nova.

So I think ideally we'd change the request_networks extension to take port-id rather than individual attributes like IP-address. This would keep the quantum code in nova really simple, which is ideal. It would make thinks slightly more complicated if you're using the nova + quantum clients, but with Horizon, or with a joint openstack client, it could be a simple workflow.

based on discussion of
https://review.openstack.org/#/c/9506/

Nachi Ueno (nati-ueno)
Changed in nova:
assignee: nobody → Nachi Ueno (nati-ueno)
Revision history for this message
Matt Dietz (cerberus) wrote :

Make sure to follow the rabbit hole all the way down. https://review.openstack.org/#/c/9295/

First of all, requested_networks isn't an extension. That means you're changing the API itself. That means you can't go changing this like it's an extension; you'd be breaking API compatibility and thus the API spec.

Revision history for this message
dan wendlandt (danwent) wrote :

I'm kind of confused, as I don't see 'networks' in the server create POST listed as part of the compute v2 API spec: http://docs.openstack.org/api/openstack-compute/2/content/CreateServers.html#d6e1247 . Am I just looking in the wrong place?

My understanding was that this functionality was a poorly documented part of the os-createserverext extension that was implemented right in code with the official server stuff. See discussion here: https://review.openstack.org/#/c/10435/ . It wasn't even supported in the nova client until I added the --nic option a while back.

Revision history for this message
Nachi Ueno (nati-ueno) wrote :

I'll add port_id in the same place where network_id is specified for now. After the nova have new extension way, I'll follow that.

--------------
For now it is fine to put it in the same place where network_id is specified. In the nova meeting on Thursday, we are going to discuss a better way to do extensions that need to do things based on additional post params.

Vish

Discussion from mailing list
https://lists.launchpad.net/openstack/msg15276.html
--------------

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/10639
Committed: http://github.com/openstack/nova/commit/51ad3d4ee9f28184510a2802867535284c0f1b8b
Submitter: Jenkins
Branch: master

commit 51ad3d4ee9f28184510a2802867535284c0f1b8b
Author: Nachi Ueno <email address hidden>
Date: Tue Jul 31 17:47:02 2012 +0000

    Adding port attribute in network parameter of boot.

    Example is (network:[{‘port’:<uuid>}] )
    The specified port will be used.
    A port who have already device_id can not be used to be boot.
    This fix is for isolating functionalities between Quantum and Nova.
    There are no need update nova side if port model will be changed
    in future quantum model. This function is for QuantumV2 api use only.
    Added port attribute in requested_network attribute. Fixes bug 1031096.

    Change-Id: Id2c86228edb0c22f536f8b36a955c87870e9d98b

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.