Instance usage audit log extension miscounts hosts

[Monsyne Dragon]

In the extension that reports the status of the instance usage audit task in nova, hosts that are disabled are not included in the count. this is incorrect. Disabled hosts can still have instances on them and are generally still running if they are not deleted, so they will (and should) run the task.

This results in the log reporting things like "100 of 95 hosts done. 0 errors" on success, which may confuse automated systems using this for monitoring.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10427

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/10427
Committed: http://github.com/openstack/nova/commit/aad7743f42e559aefde37bb44622986df4e2ae98
Submitter: Jenkins
Branch: master

commit aad7743f42e559aefde37bb44622986df4e2ae98
Author: Monsyne Dragon <email address hidden>
Date: Fri Jul 27 19:51:32 2012 +0000

    Correct host count in instance_usage_audit_log extension.

    This fixes bug 1030106. Basically we were not counting disabled hosts
    in the total host count. Also I have refactored the get_audit_task_logs
    method, it's really part of the extension (only the extension uses it),
    so I've moved it out of nova.compute.utils into the extension itself.

    (the tests that exercise it already lived in the extension's tests anyway.)

    Change-Id: Iaf42d887b824ba0cbf6ab0ed143a4c01b37b0cb1