Update server name with invalid server name is not raising BadRequest

[Harika Vakadi]

Update server name with invalid server name

Expected Result:
When name parameter of server is updated with invalid value, Bad Request Exception is supposed

Actual Result:
Did not raise Bad Request

Log:

Update name of the server with name of server to already existing ... FAIL

======================================================================
FAIL: Update name of the server with name of server to already existing
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/openstack/tempest/tempest_harika/tempest_15thJune/tempest/tempest/tests/compute/test_servers_negative.py", line 442, in test_update_server_with_name_of_server_to_already_existing
    self.server['id'], name=server_detail['name'])
AssertionError: BadRequest not raised

Input given:

new_name = 'update_!@#$%^&*()_+|={}<>?'

[Davanum Srinivas (DIMS) (dims-v)]

Where exactly do we claim that those characters are bad in a server name? is it in a api doc?

[Harika Vakadi (harika-vakadi)]

Just by validating w.r.t standards of naming conventions we have done this, sorry to say this, we do not have any documents regarding the invalid characters.

[wingwj (wingwj)]

Now, we don't reclaim invalid characters for 'name', it means we can use all characters, right?

I checked the codes, there's only length-restrict for 'name' in _validate_server_name().

[Peter Funk (pf-artcom-gmbh)]

I believe the original poster of this bug reports wants input validation
of hostnames according to RFC-952 ( http://tools.ietf.org/html/rfc952 )
(read section "ASSUMPTIONS" paragraph 1 )

[wingwj (wingwj)]

Thanks Peter,

I checked it in the AWS doc, 'server_name' param isn't used in EC2.
So, can I consider it as an invalid bug?