nova should support showing 'DELETED' servers

[Dan Prince]

Nova supports showing (HTTP GET) on deleted images and flavors. Trying to show a deleted server currently fails however:

[root@nova1 ~]# nova delete 4e38efa4-6980-44b0-8774-3a28de88e22f
[root@nova1 ~]# nova show 4e38efa4-6980-44b0-8774-3a28de88e22f
ERROR: No server with a name or ID of '4e38efa4-6980-44b0-8774-3a28de88e22f' exists.

It would seem for consistency that we should follow the model we do with images and flavors and allow 'DELETED' records that still exist in the database to be shown. See example of showing deleted image below:

[root@nova1 ~]# nova image-show 01705a39-4deb-402c-a651-e6e8bbef83ef
+----------+--------------------------------------+
| Property | Value |
+----------+--------------------------------------+
| created | 2012-05-31T20:39:36Z |
| id | 01705a39-4deb-402c-a651-e6e8bbef83ef |
| minDisk | 0 |
| minRam | 0 |
| name | foo |
| progress | 0 |
| status | DELETED |
| updated | 2012-05-31T20:39:54Z |
+----------+--------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/41054

[Matt Riedemann (mriedem)]

There is contention in the patch review so marking this as wishlist.

[Abhishek Talwar (abhishek-talwar)]

Hi All

I have been working on this bug fix and have implemented the required change but as there is a change in the functionality of nova few of the test cases fail . so please provide some knowledge how can i successfully run all the test cases.
I am not submitting a patch as Jenkins will fail it because the test cases don't pass.
So please provide some suggestions.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/122313

[Phil Day (philip-day)]

I don't think this is a valid bug. Admins can already see deleted instances by including "deleted=True" in the search options. Non admins shouldn't be able to see deleted instances.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/122313
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.