Can't create IBMi VM with RBD backend storage

[Vlad Sorokin]

When booting the RBD backend image with os_distro=ibmi got the following error in nova-compute.log and could not spin up the LPAR:

018-05-04 15:35:39.808 4237 INFO nova_powervm.virt.powervm.driver [req-ef356bb7-21fc-4069-ae67-5fc790f498bd 49a5562df86f4952a274e7deebaffc68 b57ded455d3b4e458aab759dcfa6836b - default default] [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] Operation: spawn. Virtual machine display name: vsorokin-t26, name: instance-00000060
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [req-ef356bb7-21fc-4069-ae67-5fc790f498bd 49a5562df86f4952a274e7deebaffc68 b57ded455d3b4e458aab759dcfa6836b - default default] [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] Instance failed to spawn: UnboundLocalError: local variable 'boot_conn_type' referenced before assignment
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] Traceback (most recent call last):
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 2238, in _build_resources
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] yield resources
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 2022, in _build_and_run_instance
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] block_device_info=block_device_info)
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] File "/usr/local/lib/python2.7/dist-packages/nova_powervm/virt/powervm/driver.py", line 457, in spawn
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] context, bdms, block_device_info)
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] File "/usr/local/lib/python2.7/dist-packages/nova_powervm/virt/powervm/driver.py", line 1820, in _get_boot_connectivity_type
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] return self._get_connectivity_type(bdm)
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] File "/usr/local/lib/python2.7/dist-packages/nova_powervm/virt/powervm/driver.py", line 1833, in _get_connectivity_type
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] return boot_conn_type
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] UnboundLocalError: local variable 'boot_conn_type' referenced before assignment
2018-05-04 15:35:40.853 4237 ERROR nova.compute.manager [instance: 6d9ea68b-073b-4c32-8353-0197410073ee]
2018-05-04 15:35:40.854 4237 INFO nova.compute.manager [req-ef356bb7-21fc-4069-ae67-5fc790f498bd 49a5562df86f4952a274e7deebaffc68 b57ded455d3b4e458aab759dcfa6836b - default default] [instance: 6d9ea68b-073b-4c32-8353-0197410073ee] Terminating instance

[Eric Fried (efried)]

Fix proposed in nova-powervm master: https://review.openstack.org/#/c/566420/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/567418

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566420
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=af31c9f97745a8c875cb8829482b7131da080f82
Submitter: Zuul
Branch: master

commit af31c9f97745a8c875cb8829482b7131da080f82
Author: Eric Fried <email address hidden>
Date: Fri May 4 17:51:22 2018 -0500

    Fix boot volume connectivity type discovery

    Per the referenced bug, there was a code path whereby the boot volume
    connectivity type could be unset, resulting in an exception. In fixing
    this, I discovered that we were looking for `driver_volume_type` in the
    wrong place: it should be in connection_info and we were looking for it
    under connection_info['data']. I preserved the bogus code path in case
    it's actually somehow legit, but added a path to the correct location.

    We had no direct test for this stuff, so I added that too.

    Change-Id: I78e55b3d8096d4013afd0abe1e42c32dc9697871
    Closes-Bug: #1769648

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567418
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=eb252a14ac6f08a949ded4cae7e295e5cf493547
Submitter: Zuul
Branch: stable/queens

commit eb252a14ac6f08a949ded4cae7e295e5cf493547
Author: Eric Fried <email address hidden>
Date: Fri May 4 17:51:22 2018 -0500

    Fix boot volume connectivity type discovery

    Per the referenced bug, there was a code path whereby the boot volume
    connectivity type could be unset, resulting in an exception. In fixing
    this, I discovered that we were looking for `driver_volume_type` in the
    wrong place: it should be in connection_info and we were looking for it
    under connection_info['data']. I preserved the bogus code path in case
    it's actually somehow legit, but added a path to the correct location.

    We had no direct test for this stuff, so I added that too.

    (cherry picked from commit af31c9f97745a8c875cb8829482b7131da080f82)
    Change-Id: I78e55b3d8096d4013afd0abe1e42c32dc9697871
    Closes-Bug: #1769648

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova-powervm 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova-powervm 6.0.2 release.