Glance uploads sometimes fail with certain localdisk configs

[Drew Thorstensen]

Certain Localdisk configurations have been seeing glance streaming problems. They have been hanging down in the pypowervm semaphore.

This seems to be due in part with the switch to Glance v2. It seems far more reliable to not use the iterator and instead stream to a local file pipe.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/390681

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/386113
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=6bb8c34a58d110b33c5416c2adeb81a04f560b41
Submitter: Jenkins
Branch: master

commit 6bb8c34a58d110b33c5416c2adeb81a04f560b41
Author: Drew Thorstensen <email address hidden>
Date: Thu Oct 13 13:53:00 2016 -0400

    Support segregated function for upload

    The original PowerVM Glance code used a model where it would iterate
    over the chunks and build a facade on top of that to make it look like a
    stream. We found that starting in Glance v2 that is not incredibly
    reliable.

    This has led to some bad deploys and reschedules on new hosts.

    With this change set, we take advantage of a new feature in pypowervm
    that allows us to pass in a function for the upload. The function
    passes in the path of where the image should be streamed to. We can use
    this to allow for the driver to just tell Glance to stream to a file.

    Our initial tests shows this to be significantly more reliable (no
    failed deploys since). It also has an ancillary effect where the
    download runs about two times faster.

    Change-Id: I0fcc630b55290d6bb8fcd82230b58bed81afa4f8
    Closes-Bug: #1636321

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390681
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=e2a9efc19cd2bc0b0fc79e55379a15270fca1860
Submitter: Jenkins
Branch: stable/newton

commit e2a9efc19cd2bc0b0fc79e55379a15270fca1860
Author: Drew Thorstensen <email address hidden>
Date: Thu Oct 13 13:53:00 2016 -0400

    Support segregated function for upload

    The original PowerVM Glance code used a model where it would iterate
    over the chunks and build a facade on top of that to make it look like a
    stream. We found that starting in Glance v2 that is not incredibly
    reliable.

    This has led to some bad deploys and reschedules on new hosts.

    With this change set, we take advantage of a new feature in pypowervm
    that allows us to pass in a function for the upload. The function
    passes in the path of where the image should be streamed to. We can use
    this to allow for the driver to just tell Glance to stream to a file.

    Our initial tests shows this to be significantly more reliable (no
    failed deploys since). It also has an ancillary effect where the
    download runs about two times faster.

    Change-Id: I0fcc630b55290d6bb8fcd82230b58bed81afa4f8
    Closes-Bug: #1636321