True error can get lost in getting partition state

[Drew Thorstensen]

2016-10-20 12:29:28.599 ERROR nova.compute.manager [-] [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] Periodic sync_power_state task had an error while processing an instance.
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] Traceback (most recent call last):
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] File "/opt/stack/nova/nova/compute/manager.py", line 6174, in _sync
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] query_driver_power_state_and_sync()
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 271, in inner
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] return f(*args, **kwargs)
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] File "/opt/stack/nova/nova/compute/manager.py", line 6171, in query_driver_power_state_and_sync
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] self._query_driver_power_state_and_sync(context, db_instance)
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] File "/opt/stack/nova/nova/compute/manager.py", line 6202, in _query_driver_power_state_and_sync
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] vm_power_state = vm_instance.state
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] File "/opt/stack/nova-powervm/nova_powervm/virt/powervm/vm.py", line 185, in state
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] pvm_state = self._get_property('PartitionState')
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] File "/opt/stack/nova-powervm/nova_powervm/virt/powervm/vm.py", line 176, in _get_property
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] return get_vm_qp(self._adapter, self._uuid, q_prop)
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] File "/opt/stack/nova-powervm/nova_powervm/virt/powervm/vm.py", line 533, in get_vm_qp
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] if e.response.status == 404:
2016-10-20 12:29:28.599 TRACE nova.compute.manager [instance: 70061fa7-d956-47db-bee1-2b409cb0e07e] AttributeError: 'NoneType' object has no attribute 'status'

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389339
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=af3aebdd8de62df7075aff31ab92f268d98dbeb6
Submitter: Jenkins
Branch: master

commit af3aebdd8de62df7075aff31ab92f268d98dbeb6
Author: Drew Thorstensen <email address hidden>
Date: Thu Oct 20 16:17:52 2016 -0400

    Better error handling of QP errors

    Quick property URIs could sometimes not embed a response. This is
    generally an API issue and changes have gone into pypowervm for it.
    However, nova-powervm should also be more tolerant of this.

    This change supports better toleration in the event that the error
    raised from the REST API does not have a proper response.

    Change-Id: I490731a342a3045887a47c1051448e9cd2eabb15
    Closes-Bug: 1635385

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/390968

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390968
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=c50b337256e3973b79e5ff7ad31efdbe0a71c8d2
Submitter: Jenkins
Branch: stable/newton

commit c50b337256e3973b79e5ff7ad31efdbe0a71c8d2
Author: Drew Thorstensen <email address hidden>
Date: Thu Oct 20 16:17:52 2016 -0400

    Better error handling of QP errors

    Quick property URIs could sometimes not embed a response. This is
    generally an API issue and changes have gone into pypowervm for it.
    However, nova-powervm should also be more tolerant of this.

    This change supports better toleration in the event that the error
    raised from the REST API does not have a proper response.

    Change-Id: I490731a342a3045887a47c1051448e9cd2eabb15
    Closes-Bug: 1635385
    (cherry picked from commit af3aebdd8de62df7075aff31ab92f268d98dbeb6)