live migration of instance using npiv volumes and multiple vios does not take the client slot into account

[Shyama]

Live migration fails with the below error when there are multiple ports used per VIOS for the npiv volumes on an instance

The management console may not be able to replicate the source multipath I/O configuration for the migrating partition's virtual I/O adapters on the destination. This means one or both of the following: (1) Client adapters that are assigned to different source VIOS hosts may be assigned to a single VIOS host on the destination; (2) Client adapters that are assigned to a single source VIOS host may be assigned to different VIOS hosts on the destination. You can review the complete list of management console chosen mappings by issuing the command to list the virtual I/O mappings for the migrating partition.

This happens when the client slots are not maintained on the target. For example,

Source Target
6/vios1/fcs0 (A) 6/vios1/fcs0 (A)
3/vios2/fcs0 (A) 3/vios2/fcs4 (A)
4/vios1/fcs2 (B) 4/vios2/fcs0 (B)
5/vios2/fcs2 (B) 5/vios1/fcs4 (B)

Here the vios1 has slots 6 and 4 on target and 6 and 5 on source which throws an error.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/367585
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=1e9eed79bf72e6b7d38bce86f4d807d08cff75be
Submitter: Jenkins
Branch: master

commit 1e9eed79bf72e6b7d38bce86f4d807d08cff75be
Author: Shyama Venugopal <email address hidden>
Date: Thu Sep 8 14:45:51 2016 -0400

    Build vfc mappings for migration with vios slot collocation

    The migration data on the source sets information about the slots
    which are collocated on a VIOS.

    This is used along with the fabric port information on the destination
    host to make sure the client slots are maintained on the same VIOS.

    Change-Id: Iddb4a535b67a7a157a2ac4be97a3ce028fed1696
    Closes-Bug: #1623889

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/373415

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373415
Committed: https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=cad02b6cbbab91016761a5e18a0c9baa07e792fe
Submitter: Jenkins
Branch: stable/mitaka

commit cad02b6cbbab91016761a5e18a0c9baa07e792fe
Author: Shyama Venugopal <email address hidden>
Date: Thu Sep 8 14:45:51 2016 -0400

    Build vfc mappings for migration with vios slot collocation

    The migration data on the source sets information about the slots
    which are collocated on a VIOS.

    This is used along with the fabric port information on the destination
    host to make sure the client slots are maintained on the same VIOS.

    Change-Id: Iddb4a535b67a7a157a2ac4be97a3ce028fed1696
    Closes-Bug: #1623889
    (cherry picked from commit 1e9eed79bf72e6b7d38bce86f4d807d08cff75be)