os-vif: 'create_ovs_vif_port' is no longer available - replace with os-vif module

[Alex Kavanagh]

Essentially, the function has been removed and needs to be replaced with something from the new 'os-vif' module. devstack tests are failing thus:

tempest.scenario.test_server_basic_ops.TestServerBasicOps.test_server_basic_ops[compute,id-7fff3fb3-91d8-4fd0-bd7d-0204f1f18
0ba,network,smoke]
----------------------------------------------------------------------------------------------------------------------------
------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "tempest/common/utils/__init__.py", line 88, in wrapper
        return f(*func_args, **func_kwargs)
      File "tempest/scenario/test_server_basic_ops.py", line 134, in test_server_basic_ops
        metadata=self.md)
      File "tempest/scenario/manager.py", line 210, in create_server
        image_id=image_id, **kwargs)
      File "tempest/common/compute.py", line 258, in create_test_server
        server['id'])
      File "/opt/stack/tempest/.tox/tempest/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
        self.force_reraise()
      File "/opt/stack/tempest/.tox/tempest/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_re
raise
        six.reraise(self.type_, self.value, self.tb)
      File "tempest/common/compute.py", line 229, in create_test_server
        clients.servers_client, server['id'], wait_until)
      File "tempest/common/waiters.py", line 76, in wait_for_server_status
        server_id=server_id)
    tempest.exceptions.BuildErrorException: Server 40bd024e-7c07-48eb-88ae-8441e662651a failed to build and is in ERROR stat
us
    Details: {u'message': u"Build of instance 40bd024e-7c07-48eb-88ae-8441e662651a aborted: 'module' object has no attribute
 'create_ovs_vif_port'", u'created': u'2018-06-07T15:24:21Z', u'code': 500}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/574349

[Alex Kavanagh (ajkavanagh)]

The actual issue is that the relevant functions have migrated to the os-vif package in vif_plug_ovs.linux_net.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/574349
Committed: https://git.openstack.org/cgit/openstack/nova-lxd/commit/?id=b4c89d067761cc134cb884f3356659eaa48b942f
Submitter: Zuul
Branch: master

commit b4c89d067761cc134cb884f3356659eaa48b942f
Author: Alex Kavanagh <email address hidden>
Date: Mon Jun 11 18:10:45 2018 +0100

    'create_ovs_vif_port' function moved to os-vif

    A few functions from nova migrated to os-vif, and two were the
    create_ovs_vif_port and delete_ovs_vif_port that nova-lxd uses to
    do the post vif wiring on the container to connect it to the appropriate
    bridge. This just gets the correct import, and adds a bit to the
    docstrings to help maintainers understand the code.

    Change-Id: I0787a919275c544e4faddc9d42d8db5880ba57ee
    Closes-Bug: #1776205