debug logs are not enough

Bug #1657339 reported by makocchi on 2017-01-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nova-lxd
Medium
Alex Kavanagh

Bug Description

Debug log is not enough because log format is not correct.

for example,

LOG.debug('container_init called for instance', instance=instance)

should be

LOG.debug('container_init called for %(instance)s', {'instance': instance})

makocchi (makocchi) on 2017-01-18
Changed in nova-lxd:
assignee: nobody → makocchi (makocchi)

Fix proposed to branch: master
Review: https://review.openstack.org/421679

Changed in nova-lxd:
status: New → In Progress

Change abandoned by Paul Hummer (<email address hidden>) on branch: master
Review: https://review.openstack.org/421679

James Page (james-page) on 2017-03-16
Changed in nova-lxd:
status: In Progress → Triaged
importance: Undecided → Medium
Changed in nova-lxd:
assignee: makocchi (makocchi) → nobody
assignee: nobody → Alex Kavanagh (ajkavanagh)
status: Triaged → In Progress

Reviewed: https://review.openstack.org/571748
Committed: https://git.openstack.org/cgit/openstack/nova-lxd/commit/?id=84a7945bca43205ce2c92cdd34b27da12749d24f
Submitter: Zuul
Branch: master

commit 84a7945bca43205ce2c92cdd34b27da12749d24f
Author: Alex Kavanagh <email address hidden>
Date: Fri Jun 1 15:40:14 2018 +0100

    Fix broken debug logs and modernise string interpolation

    Some of the debug logs were not actually outputing the instance;
    it was just tagged in the LOF.<type>(...) command.

    Also took the opportunity to modernise to '.format()' the string
    interpolation to meet current guidelines.

    Change-Id: I99c56ff738713140b2af16199e9e58b39bb4e396
    Closes-Bug: #1657339

Changed in nova-lxd:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers