Fix the breaking change to ComputeDriver.spawn in nova-dpm

[Sreeram Vancheeswaran]

see [1]

[1] - http://lists.openstack.org/pipermail/openstack-dev/2017-October/123738.html

[Sreeram Vancheeswaran (sreeram-vancheeswaran)]

Have fixed the root cause by adding allocations kwarg to the spawn methods in driver and test files; However hit with another issue (see below); looking into that

Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [None req-cffaeec4-f73d-4e81-b7af-8ed9d446a903 service nova] [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] Instance failed to spawn: KeyError: 'object_id'
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] Traceback (most recent call last):
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] File "/opt/stack/nova/nova/compute/manager.py", line 2208, in _build_resources
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] yield resources
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] File "/opt/stack/nova/nova/compute/manager.py", line 2001, in _build_and_run_instance
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] block_device_info=block_device_info)
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] File "/opt/stack/nova-dpm/nova_dpm/virt/dpm/driver.py", line 346, in spawn
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] nic = inst.attach_nic(vif)
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] File "/opt/stack/nova-dpm/nova_dpm/virt/dpm/vm.py", line 182, in attach_nic
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] dpm_object_id = vif_details['object_id']
Oct 26 06:36:54 zfwcec190 nova-compute[39722]: ERROR nova.compute.manager [instance: c353aeae-2ee2-446c-889c-f1cdc084c705] KeyError: 'object_id'

[Sreeram Vancheeswaran (sreeram-vancheeswaran)]

The above issue was caused my usage of wrong config file; Now the fix works fine. Fix involved adding "allocation" kwarg, and removal of "flavor=None" kwarg from spawn() methods. Some tox tests are failing, and proceeding with fixing those

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/517893

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517893
Committed: https://git.openstack.org/cgit/openstack/nova-dpm/commit/?id=1ba30f87af861056e0cee32c5887af8bd29a5f60
Submitter: Zuul
Branch: master

commit 1ba30f87af861056e0cee32c5887af8bd29a5f60
Author: Sreeram Vancheeswaran <email address hidden>
Date: Mon Nov 6 01:03:29 2017 -0800

    Fix the breaking change to ComputeDriver.spawn in nova-dpm

    Following updates are made to the signature of spawn method and its
    corresponding references in test_driver.py.
     - add "allocations" kw arg as per [1]
     - remove "flavor" kw arg as per [2]

    [1] http://lists.openstack.org/pipermail/openstack-dev/2017-October/123738.htm
    [2] https://github.com/openstack/nova-dpm/commit/8749bda96e84038e25773c0fba66106e164519f7

    Closes-Bug: 1724744

    Change-Id: I6fd6974a0b32bbcc520a2fdd2c948367f3e8ae5f
    Signed-off-by: Sreeram Vancheeswaran <email address hidden>