[TODO-zhmcclient]disable warnings when using zhmcclient code

Bug #1669299 reported by preethi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nova-dpm
Fix Released
Low
Prabhat Ranjan

Bug Description

The nova-dpm driver code currently has "requests.packages.urllib3.disable_warnings()" which helps in disabling warning especially when zhmcclient interfaces are used.

This bug is to have follow up on how to handle this in long run- either handle it in zhmcclient or handle it in the driver code.

Tags: zhmcclient
preethi (preethi.py)
summary: - disable warnings when using zhmcclient code
+ [TODO-zhmcclient]disable warnings when using zhmcclient code
Revision history for this message
Prabhat Ranjan (pranjank) wrote :

In unit test case it does not affect. I mean we are not getting any warning in unit testcase. So I will remove "requests.packages.urllib3.disable_warnings()" from unit testcase.

As far as code is concern we are using it at only one place during login.
https://github.com/openstack/nova-dpm/blob/stable/ocata/nova_dpm/virt/dpm/client_proxy.py#L41

So I think this is ok for us.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova-dpm (master)

Fix proposed to branch: master
Review: https://review.openstack.org/461679

Changed in nova-dpm:
assignee: nobody → Prabhat Ranjan (pranjank)
status: New → In Progress
Revision history for this message
Sreeram Vancheeswaran (sreeram-vancheeswaran) wrote :

@Prabhat, I agree

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova-dpm (master)

Reviewed: https://review.openstack.org/461679
Committed: https://git.openstack.org/cgit/openstack/nova-dpm/commit/?id=3a9086eca46ce01ce6bacb3c8051af74a714330d
Submitter: Jenkins
Branch: master

commit 3a9086eca46ce01ce6bacb3c8051af74a714330d
Author: Prabhat Ranjan <email address hidden>
Date: Tue May 2 14:17:11 2017 +0530

    Remove requests.packages.urllib3.disable_warnings()

    Remove requests.packages.urllib3.disable_warnings() from
    unit testcase because it is not affacting unit testcase.
    Means no warning log without
    requests.packages.urllib3.disable_warnings().

    But keep as it is in main code because we are using
    it at one place only.
    https://github.com/openstack/nova-dpm/blob/stable/ocata/nova_dpm/virt/dpm/client_proxy.py#L41

    Closes-Bug: #1669299

    Change-Id: I2eefc01743c2549ebe8cdc32eb95d03a05f7bc0f
    Signed-off-by: Prabhat Ranjan <email address hidden>

Changed in nova-dpm:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.