nova-docker

Containers fail to launch in network without gateway

Bug #1381780 reported by Jeroen van Bemmel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nova-docker
Fix Committed
Undecided
Davanum Srinivas (DIMS)

Bug Description

In https://github.com/stackforge/nova-docker/blob/master/novadocker/virt/docker/vifs.py

Line 207 utils.execute('ip', 'netns', 'exec', container_id,
                          'ip', 'route', 'replace', 'default', 'via',
                          gateway, 'dev', if_remote_name, run_as_root=True)

This fails for networks that do not have a gateway IP, fix:

if gateway is not None:
     utils.execute('ip', 'netns', 'exec', container_id,
                          'ip', 'route', 'replace', 'default', 'via',
                          gateway, 'dev', if_remote_name, run_as_root=True)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Fixed in https://review.openstack.org/130514

Changed in nova-docker:
status: New → In Progress
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova-docker (master)

Reviewed: https://review.openstack.org/130514
Committed: https://git.openstack.org/cgit/stackforge/nova-docker/commit/?id=f00e4075bc4e4837ba663a6bb51bffdc7509b301
Submitter: Jenkins
Branch: master

commit f00e4075bc4e4837ba663a6bb51bffdc7509b301
Author: Davanum Srinivas <email address hidden>
Date: Thu Oct 23 08:08:36 2014 -0400

    Fix failure to launch in network without gateway

    Check if gateway ip is specified before we try to use it

    Closes-Bug: #1381780
    Change-Id: I7f8703365e5920f0c04804b2aa6207b91d5f749e

Changed in nova-docker:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.