Using deprecated properties of Toolbar and MainView

Bug #1218497 reported by Tim Peeters on 2013-08-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
notes-app
High
Olivier Tilloy
notes-app (Ubuntu)
Undecided
Unassigned

Bug Description

This code is in NotesApp.qml:

        tools: ToolbarItems {
            ToolbarButton {
                action: Action {
                    text: i18n.tr("Add")
                    iconSource: Qt.resolvedUrl("Components/graphics/add.png")
                    onTriggered: {
                        notesMainWindow.toolbar.active = false
                        notesMainWindow.createNewNote()
                    }
                }

Toolbar.active has been deprecated for some time and is about to be removed.
MainView.toolbar does not exist. So the add button on the toolbar does not work (at least not with my UITK branch where I removed the deprecated properties).

Please remove those properties. Instead of using toolbar.active, use the 'opened' property of the ToolbarItems. These changes are needed for the toolbar code cleanup https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/toolbar-clean/+merge/181741 that is required for an MR that will follow that improves automatic reveal/hide of the toolbar.

Related branches

Tim Peeters (tpeeters) on 2013-08-29
Changed in notes-app:
importance: Undecided → High
description: updated
Olivier Tilloy (osomon) on 2013-08-29
Changed in notes-app:
status: New → Confirmed
assignee: nobody → Olivier Tilloy (osomon)
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:notes-app at revision None, scheduled for release in notes-app, milestone ubuntu-13.04-month-5

Changed in notes-app:
status: Confirmed → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package notes-app - 1.4+13.10.20130903.3-0ubuntu1

---------------
notes-app (1.4+13.10.20130903.3-0ubuntu1) saucy; urgency=low

  [ Olivier Tilloy ]
  * Update deprecated code to close the toolbar when creating a new
    note. (LP: #1218497)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 180
 -- Ubuntu daily release <email address hidden> Tue, 03 Sep 2013 15:58:50 +0000

Changed in notes-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon) on 2013-09-27
Changed in notes-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers