Use Gtk.Image from icon name instead of from Pixbuf
Bug #1469908 reported by
Danielle Foré
This bug affects 5 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Files |
Fix Released
|
Medium
|
Danielle Foré | ||
| Noise |
Fix Released
|
Medium
|
Unassigned | ||
| Slingshot |
Fix Released
|
Medium
|
Corentin Noël | ||
| Switchboard |
Fix Released
|
Medium
|
Danielle Foré | ||
Bug Description
We've discovered that most of the problems with HiDPI icon support are due to the use of Gdk.Pixbuf instead of Gtk.Image
Related branches
lp:~tintou/slingshot/no-pixbuf
- Danielle Foré: Approve (ux)
- elementary Pantheon team: Pending (code) requested
-
Diff: 400 lines (+65/-200)3 files modifiedsrc/Backend/App.vala (+24/-168)
src/Widgets/AppEntry.vala (+37/-30)
src/Widgets/SearchItem.vala (+4/-2)
lp:~elementary-apps/pantheon-files/no-pixbuf
- elementary Apps team: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/View/Sidebar.vala (+1/-1)
lp:~elementary-pantheon/switchboard/flowbox
- Adam Bieńkowski (community): Approve (testing)
-
Diff: 847 lines (+290/-398)6 files modifiedschemas/org.pantheon.switchboard.gschema.xml (+2/-2)
src/CMakeLists.txt (+2/-0)
src/CategoryView.vala (+86/-380)
src/Switchboard.vala (+10/-16)
src/Widgets/CategoryFlowBox.vala (+139/-0)
src/Widgets/CategoryIcon.vala (+51/-0)
| Changed in pantheon-files: | |
| milestone: | none → loki-beta1 |
| Changed in noise: | |
| milestone: | none → loki-beta1 |
| Changed in pantheon-photos: | |
| milestone: | none → loki-beta1 |
| Changed in slingshot: | |
| milestone: | none → loki-beta1 |
| status: | New → Confirmed |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #1 |
| Changed in noise: | |
| status: | New → Fix Committed |
| summary: |
- Use Gtk.Image instead of Gdk.Pixbuf + Use Gtk.Image from icon name instead of from Pixbuf |
| Changed in pantheon-files: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in pantheon-photos: | |
| status: | New → Confirmed |
| Changed in noise: | |
| milestone: | loki-beta1 → freya-0.3.1 |
| Changed in noise: | |
| milestone: | freya-0.3.1 → loki-beta1 |
| Changed in switchboard: | |
| importance: | Undecided → Medium |
| Changed in slingshot: | |
| importance: | Undecided → Medium |
| Changed in pantheon-photos: | |
| importance: | Undecided → Medium |
| Changed in noise: | |
| importance: | Undecided → Medium |
| Changed in pantheon-files: | |
| milestone: | loki-beta1 → loki-alpha1 |
| Changed in noise: | |
| milestone: | loki-beta1 → loki-alpha1 |
| Changed in pantheon-files: | |
| milestone: | loki-alpha1 → loki-beta1 |
| Changed in slingshot: | |
| status: | Confirmed → In Progress |
| Changed in slingshot: | |
| assignee: | nobody → Corentin Noël (tintou) |
| milestone: | loki-beta1 → loki-alpha1 |
| status: | In Progress → Fix Committed |
Revision history for this message
| Marvin Beckers (embik) wrote | #2 |
| Changed in pantheon-files: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Daniel Fore (danrabbit) |
| Changed in pantheon-files: | |
| status: | In Progress → Fix Committed |
| Changed in switchboard: | |
| milestone: | loki-beta1 → none |
| Changed in pantheon-photos: | |
| milestone: | loki-beta1 → none |
| Changed in switchboard: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Daniel Fore (danrabbit) |
| no longer affects: | pantheon-photos |
| Changed in switchboard: | |
| status: | In Progress → Fix Committed |
| milestone: | none → loki-rc1 |
| Changed in noise: | |
| status: | Fix Committed → Fix Released |
| Changed in switchboard: | |
| milestone: | loki-beta2 → 2.1.0 |
| status: | Fix Committed → Fix Released |
| Changed in slingshot: | |
| status: | Fix Committed → Fix Released |
| Changed in pantheon-files: | |
| status: | Fix Committed → Fix Released |
| milestone: | loki-beta1 → 0.3 |
To post a comment you must log in.
Most of the apps affected have issues in the sidebar or welcome screens. An easy way to test on LowDPI displays is to inspect a gtk.image with gtkinspector and look at its properties. If the "icon name" field is "null" and the "pixbuf" field has something in it, you're probably not okay.