Replace granite.statusbar with gtk.actionbar

Bug #1306282 reported by Danielle Foré
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Granite
Fix Released
Medium
Unassigned
Noise
Fix Released
Medium
Danielle Foré

Bug Description

After some discussion with Matthias Clasen, it seems gtk.actionbar might do everything that statusbar was built to do. We should investigate if we can deprecate this widget.

Related branches

Revision history for this message
Victor Martinez (victored) wrote :

In theory it can be done, but gtk.actionbar is a non-themeable container based on Gtk.Box :(

Revision history for this message
Danielle Foré (danrabbit) wrote :

Ah crap really? From my discussion with Matthias it sounded like it was themeable.

Revision history for this message
Victor Martinez (victored) wrote :

Yes :( It's sadly not themeable like every other container widget (except for Gtk.Toolbar and Gtk.HeaderBar).

It has to be packed into a themeable container in order to get a non-transparent background and border support.

That said, we can add theming support by subclassing the widget, but that would imply providing a Granite version of it. It sounds to me like we could base our current StatusBar upon Gtk.ActionBar, but not deprecate it in favor of the latter.

Revision history for this message
Victor Martinez (victored) wrote :

I was wrong.

GtkActionBar is the ideal replacement for GraniteStatusBar, and it's actually themeable!

See the linked branch for an example of how to port any app from Granite.Widgets.StatusBar to Gtk.ActionBar.

There's no reason to not deprecate Granite's StatusBar.

Changed in noise:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Daniel Fore (danrabbit)
milestone: none → isis-beta1
Changed in granite:
status: New → Triaged
importance: Undecided → Medium
tags: added: deprecation
tags: added: bitesize
RabbitBot (rabbitbot-a)
Changed in granite:
status: Triaged → Fix Committed
Changed in granite:
milestone: none → isis-beta1
Changed in noise:
status: Fix Committed → Fix Released
Changed in granite:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.