Noise

Disable notifications on settings

Bug #1044347 reported by David Gomes on 2012-08-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Noise	Fix Released	Low	greggory.hz	Noise luna-beta1 "0.1 - Bob Marley"

Bug Description

There should be a way to disable notifications on the dconf-editor.

Related branches

lp:~greggory-hz/noise/bug-1044347

Merged into lp:~elementary-apps/noise/trunk

Danielle Foré: Needs Fixing on 2012-09-27

Victor Martinez (community): Approve on 2012-09-18

David Gomes (community): Approve on 2012-09-17

lp:~elementary-apps/noise/trunk

David Gomes (davidgomes) on 2012-08-31

Changed in noise:
assignee:	nobody → David Gomes (davidgomes)
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

David Gomes (davidgomes) wrote on 2012-09-03:

I couldn't find a way to fix this bug, so it's Unassigned now.

Changed in noise:
assignee:	David Gomes (davidgomes) → nobody

Revision history for this message

Victor Martinez (victored) wrote on 2012-09-03:

David, in case you still have the time, we have a central place for showing notifications in LibraryWindow::show_notification(). Checking for settings there will affect all the notifications, so a simple return there in case they are disabled will do the trick.

I have some questions:
1) Does the design team agree with fixing this bug?
2) Are there plans to access the settings key from a switchboard plug?

Thanks in advance!

Changed in noise:
assignee:	nobody → elementary UX Team (elementary-design)

Revision history for this message

Danielle Foré (danrabbit) wrote on 2012-09-04:

Notifications Plug Edit (77.5 KiB, image/png)

Hey Victor,

I did have some ideas around a global "notification settings" plug. I think it might be better if we could solve this problem in Pantheon-notify somehow so that apps don't have to go around adding these keys themselves. But if that's not feasible, I do agree that there should be a way to enable/disable notifications as some people find them annoying.

Changed in noise:
assignee:	elementary UX Team (elementary-design) → nobody

greggory.hz (greggory-hz) on 2012-09-17

Changed in noise:
assignee:	nobody → greggory.hz (greggory-hz)

Revision history for this message

greggory.hz (greggory-hz) wrote on 2012-09-17:

I've created a branch with a fix to this here: https://code.launchpad.net/~greggory-hz/noise/bug-1044347

I'm not sure if there was ever a decision about placing this in pantheon-notify or not, but I went ahead and did this anyway because I'm looking to get familiar with the whole process and this was a light-weight introduction. If the ultimate decision is to include this functionality in pantheon-notify, I'd be willing to attempt that as well (I may need some nudges in the right direction though ...).

I'm fairly new in these parts (and to launchpad in general), so I'm not sure what the procedure is to get this reviewed. Any help would be appreciated!