Incorrect sqlheavy dependency

[Pim Vullers]

Noise still requires sqlheavy 0.1 when version 0.2 (which is optional) is available. If I'm right sqlheavy-0.1 should not be in the first list of mandatory deps, but only be requested if 0.2 is missing.

[Scott Ringwelski (sgringwe)]

Is sqlheavy 0.2 in universal?

[Pim Vullers (pimvullers)]

I don't know, I'm not using Ubuntu but Gentoo. And I build it from source.

This is the relevant part from CMakeLists.txt:

pkg_check_modules(DEPS
    REQUIRED
    glib-2.0
...
    sqlheavy-0.1
...
    libpeas-1.0)
# Check if we have sqlheavy-0.2

if(${SQLHEAVY_USE_2})
pkg_check_modules(SQLHEAVY sqlheavy-0.2)
set(ADD_PKG ${ADD_PKG} sqlheavy-0.2)
message("-- Will use sqlheavy-0.2")
else()
set(ADD_PKG ${ADD_PKG} sqlheavy-0.1)
pkg_check_modules(SQLHEAVY sqlheavy-0.1)
message("-- Will use sqlheavy-0.1")
endif()

If I'm correct sqlheavy-0.1 should dropped from the first REQUIRED list and the check should be altered to :

else()
set(ADD_PKG ${ADD_PKG} sqlheavy-0.1)
pkg_check_modules(SQLHEAVY REQUIRED sqlheavy-0.1)
message("-- Will use sqlheavy-0.1")
endif()

i.e. do not require sqlheavy-0.1 in the first place but check if sqlheavy-0.2 is available if so use that, otherwise require sqlheavy-0.1

[Scott Ringwelski (sgringwe)]

What you're suggesting is the same as what is currently implemented: require >= 0.1, using 0.2 if possible.

Since 0.2 is not in universe repos and 0.1 is, 0.1 is the required version.

[Pim Vullers (pimvullers)]

The difference is that for 0.2 to be used now, you also need to have 0.1 since otherwise the first REQUIRED check fails and it won't even get to looking for 0.2

[Pim Vullers (pimvullers)]

Could you please explain why you marked this bug as invalid?

[Corentin Noël (tintou)]

Because as you said, the 0.2 is already used if found

[Pim Vullers (pimvullers)]

The issue is that it requires 0.1 whether 0.2 is available or not. (i.e. build fails if you only have 0.2)

[Victor Martinez (victored)]

Indeed, this is a valid issue. Thanks Pim.

[Pim Vullers (pimvullers)]

victored: your commit does not completely solve this issue.

1. sqlheavy-0.1 is still in the REQUIRED DEPS list, i.e. it is still required
2. the keyword REQUIRED should be added to the pkg_check_modules call for sqlheavy-0.1 (as in comment #2), otherwise CMake will not fail if no sqlheavy version is found.

[Victor Martinez (victored)]

My bad, fixed.