neutron-sanity-check --no* BoolOpts don't work

[Terry Wilson]

neutron-sanity-check allows the passing of --config-file and --config-dir to automatically set which tests are run based on neutron's configuration. Since the test options are BoolOpts, they automatically register --no* inverse options. This implies that one could pass --config-file /etc/neutron/l3_agent.ini and then disable the dnsmasq_version check with --nodnsmasq_version.

neutron-sanity-check uses set_override() to override the test configuration, which also overrides the CLI. Using set_default() should fix the issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/284301

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284301
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c28ad6b8e38884c6e1cc7504e478608349fc0376
Submitter: Jenkins
Branch: master

commit c28ad6b8e38884c6e1cc7504e478608349fc0376
Author: Terry Wilson <email address hidden>
Date: Tue Feb 23 06:16:13 2016 -0600

    Fix sanity check --no* BoolOpts

    If --config-{file,dir} are used to genearate a list of tests to
    run, using set_override() will also override any options passed
    via the CLI.

    For example, on Centos 7 which uses dnsmasq 2.66, running:

      neutron-sanity-check --nodnsmasq_version --config-file \
        /etc/neutron/l3_agent.ini

    will still run and fail the dnsmasq version test. Using
    set_default() allows using --config-{file,dir} and --no* in
    conjunction.

    Closes-Bug: #1549394
    Change-Id: I5b9e520add7324660148c4451bbef54c0dfe428e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/284556

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/284598

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284556
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2b4838e1984ddc9d02c74b147598eda80fb7bdde
Submitter: Jenkins
Branch: stable/liberty

commit 2b4838e1984ddc9d02c74b147598eda80fb7bdde
Author: Terry Wilson <email address hidden>
Date: Tue Feb 23 06:16:13 2016 -0600

    Fix sanity check --no* BoolOpts

    If --config-{file,dir} are used to genearate a list of tests to
    run, using set_override() will also override any options passed
    via the CLI.

    For example, on Centos 7 which uses dnsmasq 2.66, running:

      neutron-sanity-check --nodnsmasq_version --config-file \
        /etc/neutron/l3_agent.ini

    will still run and fail the dnsmasq version test. Using
    set_default() allows using --config-{file,dir} and --no* in
    conjunction.

    Closes-Bug: #1549394
    Change-Id: I5b9e520add7324660148c4451bbef54c0dfe428e
    (cherry picked from commit c28ad6b8e38884c6e1cc7504e478608349fc0376)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284598
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5d920b8ad5bdadc3355da645a77377f993ae2c80
Submitter: Jenkins
Branch: stable/kilo

commit 5d920b8ad5bdadc3355da645a77377f993ae2c80
Author: Terry Wilson <email address hidden>
Date: Tue Feb 23 06:16:13 2016 -0600

    Fix sanity check --no* BoolOpts

    If --config-{file,dir} are used to genearate a list of tests to
    run, using set_override() will also override any options passed
    via the CLI.

    For example, on Centos 7 which uses dnsmasq 2.66, running:

      neutron-sanity-check --nodnsmasq_version --config-file \
        /etc/neutron/l3_agent.ini

    will still run and fail the dnsmasq version test. Using
    set_default() allows using --config-{file,dir} and --no* in
    conjunction.

    Closes-Bug: #1549394
    Change-Id: I5b9e520add7324660148c4451bbef54c0dfe428e
    (cherry picked from commit c28ad6b8e38884c6e1cc7504e478608349fc0376)
    (cherry picked from commit 03c0b797bb8a67de47f89249f91f0f250aea0227)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 7.0.4 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 2015.1.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 2015.1.4 release.