Incorrect neutron-ns-metadata command when watch_log is False

Bug #1490594 reported by Cedric Brandily
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Cedric Brandily
Kilo
Fix Committed
Undecided
Unassigned

Bug Description

neutron.agent.metadata.driver uses the option --metadata_proxy_watch_log=false to disable log watch[1] in neutron-ns-metadata-proxy but should use --nometadata_proxy_watch_log[2].

[1] metadata_proxy_watch_log = false
[2] stacktrace:

Command: ['sudo', '/usr/bin/neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ip', 'netns', 'exec', 'qdhcp-a14d7fd6-7e68-4ab0-96cf-f19d51e18434', 'neutron-ns-metadata-proxy', '--pid_file=/var/lib/neutron/external/pids/a14d7fd6-7e68-4ab0-96cf-f19d51e18434.pid', '--metadata_proxy_socket=/var/lib/neutron/metadata_proxy', '--network_id=a14d7fd6-7e68-4ab0-96cf-f19d51e18434', '--state_path=/var/lib/neutron', '--metadata_port=80', '--metadata_proxy_user=nobody', '--metadata_proxy_group=nogroup', '--debug', '--verbose', '--log-file=neutron-ns-metadata-proxy-a14d7fd6-7e68-4ab0-96cf-f19d51e18434.log', '--log-dir=/var/log/neutron', '--metadata_proxy_watch_log=false']
Exit code: 2
Stdin:
Stdout:
Stderr: usage: neutron-ns-metadata-proxy [-h] [--config-dir DIR] [--config-file PATH]
                                 [--daemonize] [--debug]
                                 [--log-config-append PATH]
                                 [--log-date-format DATE_FORMAT]
                                 [--log-dir LOG_DIR] [--log-file PATH]
                                 [--log-format FORMAT]
                                 [--metadata_port METADATA_PORT]
                                 [--metadata_proxy_group METADATA_PROXY_GROUP]
                                 [--metadata_proxy_socket METADATA_PROXY_SOCKET]
                                 [--metadata_proxy_user METADATA_PROXY_USER]
                                 [--metadata_proxy_watch_log]
                                 [--network_id NETWORK_ID] [--nodaemonize]
                                 [--nodebug] [--nometadata_proxy_watch_log]
                                 [--nouse-syslog] [--nouse-syslog-rfc-format]
                                 [--noverbose] [--pid_file PID_FILE]
                                 [--router_id ROUTER_ID]
                                 [--syslog-log-facility SYSLOG_LOG_FACILITY]
                                 [--use-syslog] [--use-syslog-rfc-format]
                                 [--verbose] [--version]
                                 [--state_path STATE_PATH]
neutron-ns-metadata-proxy: error: argument --metadata_proxy_watch_log: ignored explicit argument 'false'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/218889

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/218889
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e2fa9012fac98fb52cfaa0d342d455a95fdcf6e8
Submitter: Jenkins
Branch: master

commit e2fa9012fac98fb52cfaa0d342d455a95fdcf6e8
Author: Cedric Brandily <email address hidden>
Date: Mon Aug 31 16:40:14 2015 +0200

    Correct neutron-ns-metadata-proxy command when watch_log is False

    Neutron[1] uses the option --metadata_proxy_watch_log=false to disable
    log watch[2] in neutron-ns-metadata-proxy instances but should use the
    option --nometadata_proxy_watch_log. It implies that
    neutron-ns-metadata-proxy instances fail to start.

    This changes updates neutron[1] to use the correct option.

    The change also corrects associated functional tests[2], indeed
    metadata_proxy_watch_log option has no effect if a log_file/dir is
    defined for the agent running the neutron-ns-metadata-proxy.

    [1] neutron.agent.common.config
    [2] could be done by setting metadata_proxy_watch_log = false
    [3] neutron.tests.functional.agent.test_l3_agent

    Closes-Bug: #1490594
    Change-Id: Iaec4a78847d802234c99514313440fd7c14bc554

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/219387

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/219887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (12.9 KiB)

Reviewed: https://review.openstack.org/219887
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6f2849c91691a551447c2977ff0a1bead5d5d744
Submitter: Jenkins
Branch: feature/pecan

commit afd1983680aea739ef0e4b0ff2c07ab09c4a86fb
Author: armando-migliaccio <email address hidden>
Date: Tue Sep 1 15:45:50 2015 -0700

    Catch errors on 'port not found' while deleting subnet

    In some circumstances (like the one triggered by the test_dhcp_ipv6 testcase)
    calls to deleting a port and calls to deleting subnets can happen in straight
    sequence.

    If this happens the execution of the operations can interleave leading
    to the subnet deletion to fail because the port has already gone. This patch
    ensures a missing port is handled correctly.

    The method delete_subnet is ginormous and hence impossible to test at a unit
    level without proper refactoring. That can happen with a follow-up patch.

    Closes-bug: #1490832

    Change-Id: I80c3733c93b2b66c2a1c4bc3bc24272afdd88b1f

commit e27299c124d89145bf1bc23f057e1b124204235e
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Sep 1 11:22:39 2015 +0200

    [rpc] pull: removed a hack to avoid object backport triggered

    Since oslo.versionedobjects 0.8.0, the object is not backported if the
    requested version is the same as the latest known.

    Change-Id: Ia1e9aa77b75261e4b2d2b24f31250ce2a2f028a7

commit 7ea38a14bd32a3697b2cd72be4c947aa19378185
Author: Pavel Bondar <email address hidden>
Date: Fri Jul 24 11:50:26 2015 +0300

    Enable py34 tests for pluggable ipam backend

    Enable neutron.tests.unit.db.test_ipam_pluggable_backend.
    It was disabled after extending ipam tests to run db_base_plugin tests,
    which are not py34 compatible yet.

    Change-Id: I3ae491fa79d4c3311a86e98db3fb2f7d5926a0ba

commit a9b72392a14a114a364785cd268f0f50615f43b0
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Sep 1 04:25:00 2015 +0000

    Updated from global requirements

    Change-Id: Ie5ad70b0afbeb5502cc41f585f6a3f2942203369

commit 28e54ef089e8b3eca8e86992340530948aec12b7
Author: sridhargaddam <email address hidden>
Date: Thu Aug 27 09:49:28 2015 +0000

    Fix import path in neutron-sanity-check for ml2_sriov opts

    neutron-sanity-check fails while importing ml2_sriov
    configuration. This patch fixes the import path and
    also includes a unit test to avoid such issues.

    Closes-Bug: #1489374
    Change-Id: I4265ee78be9e7f83e35c94187d4577b32005bef9

commit 61121c5f2af27e31092db7ac6947f796198410a8
Author: armando-migliaccio <email address hidden>
Date: Wed Jul 8 13:48:11 2015 -0700

    Decentralize the managemement of service providers

    After the service split, some of the configuration, parsing and
    validation was kept in the neutron core; ultimately this needs to
    get closer to the services where it belongs.

    This patch starts from ProviderConfiguration and ServiceTypeManager
    classes, and aims at removing the hard-coded elements, like the list
    of known advanced services, so that in the long run we can make
    Neutron ea...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/219387
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=635d5cf885c47faf2b48ea88d509564f2e603dc1
Submitter: Jenkins
Branch: stable/kilo

commit 635d5cf885c47faf2b48ea88d509564f2e603dc1
Author: Cedric Brandily <email address hidden>
Date: Mon Aug 31 16:40:14 2015 +0200

    Correct neutron-ns-metadata-proxy command when watch_log is False

    Neutron[1] uses the option --metadata_proxy_watch_log=false to disable
    log watch[2] in neutron-ns-metadata-proxy instances but should use the
    option --nometadata_proxy_watch_log. It implies that
    neutron-ns-metadata-proxy instances fail to start.

    This changes updates neutron[1] to use the correct option.

    The change also corrects associated functional tests[2], indeed
    metadata_proxy_watch_log option has no effect if a log_file/dir is
    defined for the agent running the neutron-ns-metadata-proxy.

    [1] neutron.agent.common.config
    [2] could be done by setting metadata_proxy_watch_log = false
    [3] neutron.tests.functional.agent.test_l3_agent

    Closes-Bug: #1490594
    Change-Id: Iaec4a78847d802234c99514313440fd7c14bc554
    (cherry picked from commit e2fa9012fac98fb52cfaa0d342d455a95fdcf6e8)

tags: added: in-stable-kilo
Revision history for this message
Cedric Brandily (cbrandily) wrote :
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.