NSX: fake_api_client does not raise not found

Bug #1311291 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Aaron Rosen
Havana
Fix Released
Undecided
Unassigned
Icehouse
New
Undecided
Unassigned

Bug Description

If one queries nsx doing GET /ws.v1/lswitch/LS_UUID/lport/tag=blah and LS_UUID is a UUID and not * nsx returns 404 instead of a result list.

Aaron Rosen (arosen)
Changed in neutron:
assignee: nobody → Aaron Rosen (arosen)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89685

Changed in neutron:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Related fix proposed to neutron (stable/havana)

Related fix proposed to branch: stable/havana
Review: https://review.openstack.org/89687

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/89685
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd143a619900792a0563b9ac4fe1f78197291d94
Submitter: Jenkins
Branch: master

commit dd143a619900792a0563b9ac4fe1f78197291d94
Author: Aaron Rosen <email address hidden>
Date: Tue Apr 22 12:46:08 2014 -0700

    NSX: Fix fake_api_client to raise NotFound

    If one quries NSX doing GET /ws.v1/lswitch/LS_UUID/lport and LS_UUID
    is a UUID that does not exist in NSX. NSX raises a 404. If LS_UUID is *
    NSX returns an empty result string. This patch fixes the fake_api_client
    so that it's behavior is correct.

    Change-Id: Id66299d6ae3cfa43a65d4cb28f34348d64d8ed65
    Closes-bug: 1311291

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/89973

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/89973
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e0deffc71e5031059530b9b6c2ef3b0765de3d10
Submitter: Jenkins
Branch: stable/icehouse

commit e0deffc71e5031059530b9b6c2ef3b0765de3d10
Author: Aaron Rosen <email address hidden>
Date: Tue Apr 22 12:46:08 2014 -0700

    NSX: Fix fake_api_client to raise NotFound

    If one quries NSX doing GET /ws.v1/lswitch/LS_UUID/lport and LS_UUID
    is a UUID that does not exist in NSX. NSX raises a 404. If LS_UUID is *
    NSX returns an empty result string. This patch fixes the fake_api_client
    so that it's behavior is correct.

    Change-Id: Id66299d6ae3cfa43a65d4cb28f34348d64d8ed65
    Closes-bug: 1311291
    (cherry picked from commit dd143a619900792a0563b9ac4fe1f78197291d94)

tags: added: in-stable-icehouse
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Related fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/89687
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0b8acf684b5c8043ccdddb64ced100cd2279ad94
Submitter: Jenkins
Branch: stable/havana

commit 0b8acf684b5c8043ccdddb64ced100cd2279ad94
Author: Aaron Rosen <email address hidden>
Date: Tue Apr 22 12:51:24 2014 -0700

    NSX: Fix 404 from raising on update_port if lswitch not in nsx

    If one calls update_port and the lport is not stored in the nvp_lport_mapping
    table in the database and the lswitch the lport resides on is not in nsx
    we should catch NotFound and return the port in error state. This patch fixes
    this for havana and also corrects the fake_api_client to raise NotFound in this
    case. This problem does not exist in IceHouse though as we query NSX with *
    which does not raise NotFound.

    Change-Id: Ia01f900ade714b512b49fd3e803159a27599fee1
    Closes-bug: #1311300
    Related-bug: #1311291

tags: added: in-stable-havana
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.