add retry support to python-quantumclient

Bug #937379 reported by dan wendlandt on 2012-02-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Maru Newby

Bug Description

This was already done for melange: https://review.openstack.org/#change,4027

A similar mechanism can be used for Quantum

Maru Newby (maru) on 2012-02-29
Changed in quantum:
assignee: nobody → Maru Newby (maru)
Maru Newby (maru) wrote :

A few questions:

 - The melange change is for nova. Is this bug intended to fix nova as well?
 - The melange change was to was nova/network/quantum/melange_connection.py. Should the quantum change target nova/network/quantum/quantum_connection.py or some other module?

dan wendlandt (danwent) wrote :

It actually might be better to add configurable retry support to the Quantum client library itself: https://github.com/openstack/python-novaclient .

Currently, QuantumManager in Nova has its own copy of the Quantum client, but we'll remove that early in Folsom and replace it with a dependency on python-quantumclient. Would be good to add support to the client lib itself, then add a flag to nova to pass to the client lib.

Adding it to the client lib also means that other code using the client lib can benefit from it.

Fix proposed to branch: master
Review: https://review.openstack.org/4847

Changed in quantum:
status: New → In Progress
dan wendlandt (danwent) on 2012-03-06
Changed in quantum:
milestone: none → essex-rc1
Maru Newby (maru) on 2012-03-10
tags: added: low-hanging-fruit
dan wendlandt (danwent) on 2012-03-13
summary: - add retry support to Quantum Manager
+ add retry support to python-quantumclient
Changed in quantum:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/4847
Committed: http://github.com/openstack/python-quantumclient/commit/36fd3ac6c12b3b786c5a7d8fa958b523a7af111c
Submitter: Jenkins
Branch: master

commit 36fd3ac6c12b3b786c5a7d8fa958b523a7af111c
Author: Maru Newby <email address hidden>
Date: Fri Mar 2 15:44:51 2012 -0800

    Add retry support to the quantum client.

     * Based on the retry support in nova's melange_connection
       and glance
     * Retry configuration is defined during Client instantiation and
       only applied to idempotent GET requests
     * Updated all api methods to call http method helpers (delete/get/post/put)
       rather than do_request to ensure consistent behavoir for a given http
       method.
     * Fixed bug in quantum.common.exceptions.QuantumClientException that
       was unnecessarily overriding class's 'message' attribute.
     * Resolves bug 937379

    Change-Id: Iab4e2ccf97937502ee0df58dba1e2dca30a36df8

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-03-19
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in quantum:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers