PEP8 quantum cleanup

Bug #911663 reported by Zhongyue Luo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Zhongyue Luo
quantum (Ubuntu)
Fix Released
Undecided
Unassigned
Nominated for Precise by Yolanda Robla

Bug Description

The None, True, and False values are singletons.

All variable *comparisons* to singletons should use 'is' or 'is not'.
All variable *evaluations* to boolean should use 'if' or 'if not'.
All Object type comparisons should use isinstance() instead of comparing types directly.

Zhongyue Luo (zyluo)
Changed in quantum:
assignee: nobody → LZY (lzyeval)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/2781

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/2781
Committed: http://github.com/openstack/quantum/commit/4572e6500ace4996f63fb12f09808346e87f9551
Submitter: Jenkins
Branch: master

commit 4572e6500ace4996f63fb12f09808346e87f9551
Author: lzyeval <email address hidden>
Date: Wed Jan 4 17:10:35 2012 +0800

    PEP8 quantum cleanup

    Fixes bug #911663

    The None, True, and False values are singletons.

    All variable *comparisons* to singletons should use 'is' or 'is not'.
    All variable *evaluations* to boolean should use 'if' or 'if not'.
    All Object type comparisons should use isinstance()
    instead of comparing types directly.

    Change-Id: Id5c797d3339d0d7015bac386088133540f0c0c9e

Changed in quantum:
status: In Progress → Fix Committed
dan wendlandt (danwent)
Changed in quantum:
milestone: none → essex-3
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: essex-3 → 2012.1
Changed in quantum (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.