OpenStack Neutron (virtual network service)

Pylint errors caused by the ext framework

Reported by Ying Liu on 2011-08-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Unassigned

Bug Description

In current extension framework, the action or resource mapper all uses "id" as the variable name for the resource instance's identifier. Based on this, we must use "id" in some of our api extension functions.
But "id" is an invalid name with Pylint. Hence, we saw many pylint errors. To fix them, we need to first get ext framework change all the "id" variables.

We have exactly the same problem in the API layer.
The problem with variables named "id" is the most tricky one.

I'm tracking pylint fixes with this bug: https://bugs.launchpad.net/quantum/+bug/822813

We could use this bug report to specifically track resolution of the problem with identifiers named "id".

Changed in quantum:
milestone: none → diablo-rbp
Changed in quantum:
assignee: nobody → Salvatore Orlando (salvatore-orlando)

This bug fix, in my opinion, will require changes in the WSGI middleware, and possibly also routes mapping.
The 'id' parameter is extracted from the wsgiorg.routing.args dictionary associated with the request.

A rather dirty fix would consist in adding to arg_dict an attribute with a name such as "resource_id" and assign it the value of the "id" attribute.

However, taking into account that the only benefit is a Pylint score improvement, I don't feel this is the kind of change we want to do when we are so close to release date.

I therefore propose to un-target this bug. If somebody else wants to have a crack at it, please assign the bug to yourself. I'm not actively working on it.

Unassigning myself from this bug.

Changed in quantum:
assignee: Salvatore Orlando (salvatore-orlando) → nobody
dan wendlandt (danwent) on 2011-09-07
Changed in quantum:
milestone: diablo-rbp → none
dan wendlandt (danwent) wrote :

changes sound non-trivial, probably not worth it just to make pylint happy.

Changed in quantum:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers