Deadlock when metadata agent starts

[Jakub Libosvar]

There is a small chance that if a port binding update event occurs right after SB IDL was instantiated and before the post_fork event is set, the event match function calls to sb_idl attribute that waits indefinitely.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/934188

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.2
Review: https://review.opendev.org/c/openstack/neutron/+/934340

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/934188
Committed: https://opendev.org/openstack/neutron/commit/d8884a99e03533533f7bacef598e9a6af592e3fa
Submitter: "Zuul (22348)"
Branch: master

commit d8884a99e03533533f7bacef598e9a6af592e3fa
Author: Jakub Libosvar <email address hidden>
Date: Tue Nov 5 21:37:31 2024 +0000

    OVN metadata agent additional_chassis detection

    The patch changes how additional_chassis column support is handled in
    events. We cannot call to IDL from the match methods because the post
    fork event might not be set yet right after IDL was instantiated. If
    between the IDL instantiation and the post fork event set an event
    calling to IDL is processed, the match event method will wait
    indefinitely. This patch removes the call to IDL in the match method.

    Closes-Bug: #2086740
    Change-Id: Ibc7d9b4dd196bed65cff73b79d78122f70aac1a7
    Signed-off-by: Jakub Libosvar <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/neutron/+/934461

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 26.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/934461
Committed: https://opendev.org/openstack/neutron/commit/a792f9f7e5735f6df0f2dd1cbe5ec7e19e5a61f2
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit a792f9f7e5735f6df0f2dd1cbe5ec7e19e5a61f2
Author: Jakub Libosvar <email address hidden>
Date: Tue Nov 5 21:37:31 2024 +0000

    OVN metadata agent additional_chassis detection

    The patch changes how additional_chassis column support is handled in
    events. We cannot call to IDL from the match methods because the post
    fork event might not be set yet right after IDL was instantiated. If
    between the IDL instantiation and the post fork event set an event
    calling to IDL is processed, the match event method will wait
    indefinitely. This patch removes the call to IDL in the match method.

    Closes-Bug: #2086740
    Change-Id: Ibc7d9b4dd196bed65cff73b79d78122f70aac1a7
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit d8884a99e03533533f7bacef598e9a6af592e3fa)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/934340
Committed: https://opendev.org/openstack/neutron/commit/8e47490f7dcfe85ebf57acda354ca0a2edad34e1
Submitter: "Zuul (22348)"
Branch: stable/2024.2

commit 8e47490f7dcfe85ebf57acda354ca0a2edad34e1
Author: Jakub Libosvar <email address hidden>
Date: Tue Nov 5 21:37:31 2024 +0000

    OVN metadata agent additional_chassis detection

    The patch changes how additional_chassis column support is handled in
    events. We cannot call to IDL from the match methods because the post
    fork event might not be set yet right after IDL was instantiated. If
    between the IDL instantiation and the post fork event set an event
    calling to IDL is processed, the match event method will wait
    indefinitely. This patch removes the call to IDL in the match method.

    Closes-Bug: #2086740
    Change-Id: Ibc7d9b4dd196bed65cff73b79d78122f70aac1a7
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit d8884a99e03533533f7bacef598e9a6af592e3fa)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 25.1.0 Dalmatian release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 24.1.0 Caracal release.