[OVN] Revision number registers must be filtered by resource ID and type

[Rodolfo Alonso]

The OVN revision numbers have a multicolumn index: (resource_uuid, resource_type) [1]. In particular because of the Neutron ports that belong to a router. A router interface is a single Neutron register ("ports"). But in OVN two registers are created: "Logical_Switch_Ports" and "Logical_Router_Ports".

When retrieving a register "ovn_revision_numbers" from the Neutron database, it is needed to provide both the resource_uuid and the resource_type [2].

[1]https://github.com/openstack/neutron/blob/febdfb5d8b1cf261c13b40e330d91a5bcb6c7642/neutron/db/models/ovn.py#L41-L46
[2]https://github.com/openstack/neutron/blob/febdfb5d8b1cf261c13b40e330d91a5bcb6c7642/neutron/db/ovn_revision_numbers_db.py#L159-L167

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Any patch fixing this issue should be backported up to the oldest active branch (2023.1 right now).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/933752

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.2
Review: https://review.opendev.org/c/openstack/neutron/+/934023

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/neutron/+/934024

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/934025

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/934026

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/933752
Committed: https://opendev.org/openstack/neutron/commit/a298a37fe7ee41d25db02fdde36e134b01ef5d9a
Submitter: "Zuul (22348)"
Branch: master

commit a298a37fe7ee41d25db02fdde36e134b01ef5d9a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Oct 30 00:58:16 2024 +0000

    [OVN] Fix the revision number retrieval method

    The "ovn_revision_numbers" table has a unique constraint that is a
    combination of the "resource_uuid" and the "resource_type". There is
    a case where the resource_uuid can be the same for two registers.
    A router interface will create a single Neutron DB register ("ports")
    but it will require two OVN DB registers ("Logical_Switch_Port" and
    "Logical_Router_Ports"). In this case is needed to define the
    "resource_type" when retrieving the revision number.

    The exception "RevisionNumberNotDefined" will be thrown if only the
    "resource_uuid" is provided in the related case.

    Closes-Bug: #2085946
    Change-Id: I12079de78773f7409503392d4791848aea90cb7b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/934024
Committed: https://opendev.org/openstack/neutron/commit/2d376a76c9298ce225c9dc49c16e6fd92aca55cd
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 2d376a76c9298ce225c9dc49c16e6fd92aca55cd
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Oct 30 00:58:16 2024 +0000

    [OVN] Fix the revision number retrieval method

    The "ovn_revision_numbers" table has a unique constraint that is a
    combination of the "resource_uuid" and the "resource_type". There is
    a case where the resource_uuid can be the same for two registers.
    A router interface will create a single Neutron DB register ("ports")
    but it will require two OVN DB registers ("Logical_Switch_Port" and
    "Logical_Router_Ports"). In this case is needed to define the
    "resource_type" when retrieving the revision number.

    The exception "RevisionNumberNotDefined" will be thrown if only the
    "resource_uuid" is provided in the related case.

    Closes-Bug: #2085946
    Change-Id: I12079de78773f7409503392d4791848aea90cb7b
    (cherry picked from commit a298a37fe7ee41d25db02fdde36e134b01ef5d9a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/934025
Committed: https://opendev.org/openstack/neutron/commit/de11a56f5ada9a6695cff2c63803f2c80230fc19
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit de11a56f5ada9a6695cff2c63803f2c80230fc19
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Oct 30 00:58:16 2024 +0000

    [OVN] Fix the revision number retrieval method

    The "ovn_revision_numbers" table has a unique constraint that is a
    combination of the "resource_uuid" and the "resource_type". There is
    a case where the resource_uuid can be the same for two registers.
    A router interface will create a single Neutron DB register ("ports")
    but it will require two OVN DB registers ("Logical_Switch_Port" and
    "Logical_Router_Ports"). In this case is needed to define the
    "resource_type" when retrieving the revision number.

    The exception "RevisionNumberNotDefined" will be thrown if only the
    "resource_uuid" is provided in the related case.

    Closes-Bug: #2085946
    Change-Id: I12079de78773f7409503392d4791848aea90cb7b
    (cherry picked from commit a298a37fe7ee41d25db02fdde36e134b01ef5d9a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/934026
Committed: https://opendev.org/openstack/neutron/commit/989892ea13817f8a5bfbc3e6f053643f21fd02c7
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 989892ea13817f8a5bfbc3e6f053643f21fd02c7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Oct 30 00:58:16 2024 +0000

    [OVN] Fix the revision number retrieval method

    The "ovn_revision_numbers" table has a unique constraint that is a
    combination of the "resource_uuid" and the "resource_type". There is
    a case where the resource_uuid can be the same for two registers.
    A router interface will create a single Neutron DB register ("ports")
    but it will require two OVN DB registers ("Logical_Switch_Port" and
    "Logical_Router_Ports"). In this case is needed to define the
    "resource_type" when retrieving the revision number.

    The exception "RevisionNumberNotDefined" will be thrown if only the
    "resource_uuid" is provided in the related case.

    Closes-Bug: #2085946
    Change-Id: I12079de78773f7409503392d4791848aea90cb7b
    (cherry picked from commit a298a37fe7ee41d25db02fdde36e134b01ef5d9a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/934023
Committed: https://opendev.org/openstack/neutron/commit/245d8266d52fb213e527c97c458d41159c578117
Submitter: "Zuul (22348)"
Branch: stable/2024.2

commit 245d8266d52fb213e527c97c458d41159c578117
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Oct 30 00:58:16 2024 +0000

    [OVN] Fix the revision number retrieval method

    The "ovn_revision_numbers" table has a unique constraint that is a
    combination of the "resource_uuid" and the "resource_type". There is
    a case where the resource_uuid can be the same for two registers.
    A router interface will create a single Neutron DB register ("ports")
    but it will require two OVN DB registers ("Logical_Switch_Port" and
    "Logical_Router_Ports"). In this case is needed to define the
    "resource_type" when retrieving the revision number.

    The exception "RevisionNumberNotDefined" will be thrown if only the
    "resource_uuid" is provided in the related case.

    Closes-Bug: #2085946
    Change-Id: I12079de78773f7409503392d4791848aea90cb7b
    (cherry picked from commit a298a37fe7ee41d25db02fdde36e134b01ef5d9a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 26.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 2023.1-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.3.0 Bobcat release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 25.1.0 Dalmatian release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 24.1.0 Caracal release.