[ovn-octavia-provider] Fully populated LB wrong member subnet id when not specified

Bug #2079813 reported by Fernando Royo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Fernando Royo

Bug Description

When a fully populated LB is created, if the member is not created indicating the subnet_id to whom it belongs, the LB vip_network_id is inherit by error as member.subnet_id [1]

If the member subnet_id is indicated in the call or added after LB creation in a later step this issue is not happening.

[1] https://opendev.org/openstack/ovn-octavia-provider/blame/commit/0673f16fc68d80c364ed8907b26c061be9b8dec1/ovn_octavia_provider/driver.py#L118

Changed in neutron:
assignee: nobody → Fernando Royo (froyoredhat)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (master)
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (master)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/928335
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/6e2ba02339cdb06a63abc74a2b58f993d0560d9c
Submitter: "Zuul (22348)"
Branch: master

commit 6e2ba02339cdb06a63abc74a2b58f993d0560d9c
Author: Fernando Royo <email address hidden>
Date: Fri Sep 6 12:27:56 2024 +0200

    Fix member subnet id on a fully populated LB

    When a fully populated LB is created, if the member is not created
    indicating the subnet_id to whom it belongs, the LB vip_network_id
    is inherit by error as member.subnet_id.

    This patch fix this behaviour to inherit the member.subnet_id from
    the loadbalancer.vip_subnet_id that is always passed from Octavia
    API when call is redirect to the OVN-provider.

    Closes-Bug: #2079813
    Change-Id: I098afab053119d1a6eac86a12c1a20cc312b06ef

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/2024.1)

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/928887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/928888

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/928890

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 7.0.0.0rc1

This issue was fixed in the openstack/ovn-octavia-provider 7.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ovn-octavia-provider (stable/2023.1)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/928890
Reason: stable/2023.1 branch of openstack/ovn-octavia-provider is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/2023.1 if you want to further work on this patch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/928888
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/e5eefc4884e9b2ca17d082b37ff778f296c0066d
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit e5eefc4884e9b2ca17d082b37ff778f296c0066d
Author: Fernando Royo <email address hidden>
Date: Fri Sep 6 12:27:56 2024 +0200

    Fix member subnet id on a fully populated LB

    When a fully populated LB is created, if the member is not created
    indicating the subnet_id to whom it belongs, the LB vip_network_id
    is inherit by error as member.subnet_id.

    This patch fix this behaviour to inherit the member.subnet_id from
    the loadbalancer.vip_subnet_id that is always passed from Octavia
    API when call is redirect to the OVN-provider.

    Closes-Bug: #2079813
    Change-Id: I098afab053119d1a6eac86a12c1a20cc312b06ef
    (cherry picked from commit 6e2ba02339cdb06a63abc74a2b58f993d0560d9c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/2024.1)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/928887
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/17166191859bda54e027170762a5645ef8b4379d
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 17166191859bda54e027170762a5645ef8b4379d
Author: Fernando Royo <email address hidden>
Date: Fri Sep 6 12:27:56 2024 +0200

    Fix member subnet id on a fully populated LB

    When a fully populated LB is created, if the member is not created
    indicating the subnet_id to whom it belongs, the LB vip_network_id
    is inherit by error as member.subnet_id.

    This patch fix this behaviour to inherit the member.subnet_id from
    the loadbalancer.vip_subnet_id that is always passed from Octavia
    API when call is redirect to the OVN-provider.

    Closes-Bug: #2079813
    Change-Id: I098afab053119d1a6eac86a12c1a20cc312b06ef
    (cherry picked from commit 6e2ba02339cdb06a63abc74a2b58f993d0560d9c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 5.1.0

This issue was fixed in the openstack/ovn-octavia-provider 5.1.0 Bobcat release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.