Router disable fails with exception when FWaaS flow logging is enabled

Bug #2078918 reported by Darin Chakalov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
In Progress
Undecided
Darin Chakalov

Bug Description

When flow logging is enabled, try

router set --disable <router>
And in neutron-l3-agent.log you’ll see:

2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent [-] Error while deleting router ac2068d0-2dba-4411-b74e-e5fd5ecd1179: TypeError: unhashable type: 'dict'
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent Traceback (most recent call last):
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent File "/var/lib/kolla/venv/lib64/python3.11/site-packages/neutron/agent/l3/agent.py", line 514, in _safe_router_removed
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent self.l3_ext_manager.delete_router(self.context, ri.router)
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent File "/var/lib/kolla/venv/lib64/python3.11/site-packages/neutron/agent/l3/l3_agent_extensions_manager.py", line 63, in delete_router
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent extension.obj.delete_router(context, data)
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent File "/var/lib/kolla/venv/lib64/python3.11/site-packages/neutron/services/logapi/agent/l3/base.py", line 105, in delete_router
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent self.log_driver.stop_logging(context, router_info=data)
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent File "/var/lib/kolla/venv/lib64/python3.11/site-packages/neutron_fwaas/services/logapi/agents/drivers/iptables/log.py", line 250, in stop_logging
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent self._cleanup_nflog_process(router_info)
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent File "/var/lib/kolla/venv/lib64/python3.11/site-packages/neutron_fwaas/services/logapi/agents/drivers/iptables/log.py", line 180, in _cleanup_nflog_process
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent if router_info in self.nflog_proc_map:
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent TypeError: unhashable type: 'dict'
2024-08-21 06:59:47.588 16 ERROR neutron.agent.l3.agent
2024-08-21 06:59:47.589 16 WARNING neutron.agent.l3.agent [-] Hit retry limit with router update for ac2068d0-2dba-4411-b74e-e5fd5ecd1179, action 3

The issue is caused by an incorrect key lookup which was preventing the killing of the process on router deletion which was leading to orphaned processes

Suggesded fix: https://review.opendev.org/c/openstack/neutron-fwaas/+/927905

Tags: fwaas
Changed in neutron:
assignee: nobody → Darin Chakalov (dchakalov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas (master)

Change abandoned by "Darin Chakalov <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron-fwaas/+/927902
Reason: mistake

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Darin Chakalov <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron-fwaas/+/927904
Reason: mistake

tags: added: fwaas
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron-fwaas/+/927905
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.