Show some error in logs when failing to load nb connection certificate

[Chris Buggy]

When ovn-provider (api or driver-agent) start up they should connect to OVN NB/SB db using certificates in case they are configured in config file. Currently in case any of those files are not found they avoid the connection and no msg on the logs are shown.

[yatin (yatinkarel)]

Proposed patch from Chris https://review.opendev.org/c/openstack/ovn-octavia-provider/+/924059

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/924059
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/efd63d1721742400e7ba2c0bfc55249ef15fc549
Submitter: "Zuul (22348)"
Branch: master

commit efd63d1721742400e7ba2c0bfc55249ef15fc549
Author: Chris Buggy <email address hidden>
Date: Mon Jul 29 15:16:30 2024 +0200

    Error log for missing certs with NB and SB DBs

    When the ovn-provider starts up,
    it attempts to connect to the NB and SB databases
    by retrieving SSL and cert files.
    To avoid errors, the code will now check if these
    files exist before using them.
    If the files are missing,
    connections will be skipped and an error message
    will be displayed in the logs.

    Refactoring _check_and_set_ssl_files method to be
    public and reusable. it will now check to see if a
    string value is set and will now check path and
    LOG an error message if not found.

    Adding unit tests for ovsdb_monitor to bring up test coverage.
    Updated ovsdb_tests to improve code.

    Closes-Bug: #2072978
    Change-Id: I2a21b94fee03767a5f703486bdab2908cda18746

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/927114

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/927174

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/927203

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/927114
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/edd18767d4d1934bdf329dca6475a728848ad211
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit edd18767d4d1934bdf329dca6475a728848ad211
Author: Chris Buggy <email address hidden>
Date: Mon Jul 29 15:16:30 2024 +0200

    Error log for missing certs with NB and SB DBs

    When the ovn-provider starts up,
    it attempts to connect to the NB and SB databases
    by retrieving SSL and cert files.
    To avoid errors, the code will now check if these
    files exist before using them.
    If the files are missing,
    connections will be skipped and an error message
    will be displayed in the logs.

    Refactoring _check_and_set_ssl_files method to be
    public and reusable. it will now check to see if a
    string value is set and will now check path and
    LOG an error message if not found.

    Adding unit tests for ovsdb_monitor to bring up test coverage.
    Updated ovsdb_tests to improve code.

    Closes-Bug: #2072978
    Change-Id: I2a21b94fee03767a5f703486bdab2908cda18746
    (cherry picked from commit efd63d1721742400e7ba2c0bfc55249ef15fc549)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/927203
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/d5a7e96a66a636fcd5496c582315ee175ec19e9a
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit d5a7e96a66a636fcd5496c582315ee175ec19e9a
Author: Chris Buggy <email address hidden>
Date: Mon Jul 29 15:16:30 2024 +0200

    Error log for missing certs with NB and SB DBs

    When the ovn-provider starts up,
    it attempts to connect to the NB and SB databases
    by retrieving SSL and cert files.
    To avoid errors, the code will now check if these
    files exist before using them.
    If the files are missing,
    connections will be skipped and an error message
    will be displayed in the logs.

    Refactoring _check_and_set_ssl_files method to be
    public and reusable. it will now check to see if a
    string value is set and will now check path and
    LOG an error message if not found.

    Adding unit tests for ovsdb_monitor to bring up test coverage.
    Updated ovsdb_tests to improve code.

    Closes-Bug: #2072978
    Change-Id: I2a21b94fee03767a5f703486bdab2908cda18746
    (cherry picked from commit efd63d1721742400e7ba2c0bfc55249ef15fc549)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/927174
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/c3c6ed9bba53b9656dd8efdc3142d5d9f72440f3
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit c3c6ed9bba53b9656dd8efdc3142d5d9f72440f3
Author: Chris Buggy <email address hidden>
Date: Mon Jul 29 15:16:30 2024 +0200

    Error log for missing certs with NB and SB DBs

    When the ovn-provider starts up,
    it attempts to connect to the NB and SB databases
    by retrieving SSL and cert files.
    To avoid errors, the code will now check if these
    files exist before using them.
    If the files are missing,
    connections will be skipped and an error message
    will be displayed in the logs.

    Refactoring _check_and_set_ssl_files method to be
    public and reusable. it will now check to see if a
    string value is set and will now check path and
    LOG an error message if not found.

    Adding unit tests for ovsdb_monitor to bring up test coverage.
    Updated ovsdb_tests to improve code.

    Closes-Bug: #2072978
    Change-Id: I2a21b94fee03767a5f703486bdab2908cda18746
    (cherry picked from commit efd63d1721742400e7ba2c0bfc55249ef15fc549)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 7.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2023.1-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 5.1.0 Bobcat release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 6.0.1 Caracal release.