Restarting octavia breaks IPv4 Load Balancers with health checks

[alisafari]

After implementing IPv6 health check support in change #919229 for the ovn-octavia-provider, it appears that the maintenance task is inadvertently deleting the `ip_port_mappings` of IPv4 load balancers. This issue results in the load balancers ceasing to function upon the restart of Octavia.

I found this as a potential fix for this issue: [Proposed Fix](https://review.opendev.org/c/openstack/ovn-octavia-provider/+/923196).

[yatin (yatinkarel)]

Thanks alisafari for the bug report, seems you meant https://review.opendev.org/c/openstack/ovn-octavia-provider/+/911413 instead of #919229 as 911413 introduced the clearing of mappings?

[yatin (yatinkarel)]

Assigned to Pavlo Shchelokovskyy considering the mentioned potential fix, if untrue can be updated.

[Fernando Royo (froyoredhat)]

I will check during this afternoon the mentioned issue here, because branch https://review.opendev.org/c/openstack/ovn-octavia-provider/+/923196/1/ovn_octavia_provider/maintenance.py#149 should be don't make any change on a IPv4 LB... I will update here as soon I have tested.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/923196
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/ae1540bb1a04464c7065e542ec5e981947247f3b
Submitter: "Zuul (22348)"
Branch: master

commit ae1540bb1a04464c7065e542ec5e981947247f3b
Author: Vasyl Saienko <email address hidden>
Date: Mon Jul 1 10:37:14 2024 +0300

    Maintenance task: do not change IPv4 ip_port_mappings

    IPv4 port mappings would get cleared by format_ip_port_mappings_ipv6(),
    breaking load balancers with health monitors.

    Change-Id: Ia29fd3c533b40f6eb13278a163ebb95465d77a99
    Closes-Bug: #2072754
    Co-Authored-By: Pierre Riteau <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/926713

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/926714

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/926715

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/926713
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/8cabfc5b7cf630d72162c0980f77708a65086ea7
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 8cabfc5b7cf630d72162c0980f77708a65086ea7
Author: Vasyl Saienko <email address hidden>
Date: Mon Jul 1 10:37:14 2024 +0300

    Maintenance task: do not change IPv4 ip_port_mappings

    IPv4 port mappings would get cleared by format_ip_port_mappings_ipv6(),
    breaking load balancers with health monitors.

    Change-Id: Ia29fd3c533b40f6eb13278a163ebb95465d77a99
    Closes-Bug: #2072754
    Co-Authored-By: Pierre Riteau <email address hidden>
    (cherry picked from commit ae1540bb1a04464c7065e542ec5e981947247f3b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/926715
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/ecb8dc1ba6487ee8148513a1e72888b167980dfd
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit ecb8dc1ba6487ee8148513a1e72888b167980dfd
Author: Vasyl Saienko <email address hidden>
Date: Mon Jul 1 10:37:14 2024 +0300

    Maintenance task: do not change IPv4 ip_port_mappings

    IPv4 port mappings would get cleared by format_ip_port_mappings_ipv6(),
    breaking load balancers with health monitors.

    Change-Id: Ia29fd3c533b40f6eb13278a163ebb95465d77a99
    Closes-Bug: #2072754
    Co-Authored-By: Pierre Riteau <email address hidden>
    (cherry picked from commit ae1540bb1a04464c7065e542ec5e981947247f3b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/926714
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/6823f39399313fbefadc2860956c52268f7f2e77
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 6823f39399313fbefadc2860956c52268f7f2e77
Author: Vasyl Saienko <email address hidden>
Date: Mon Jul 1 10:37:14 2024 +0300

    Maintenance task: do not change IPv4 ip_port_mappings

    IPv4 port mappings would get cleared by format_ip_port_mappings_ipv6(),
    breaking load balancers with health monitors.

    Change-Id: Ia29fd3c533b40f6eb13278a163ebb95465d77a99
    Closes-Bug: #2072754
    Co-Authored-By: Pierre Riteau <email address hidden>
    (cherry picked from commit ae1540bb1a04464c7065e542ec5e981947247f3b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 7.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2023.1-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 5.1.0 Bobcat release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 6.0.1 Caracal release.