[eventlet-deprecation][WSGI] Missing periodic workers when using WSGI server

Bug #2069581 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

Since [1], the Neutron API spawns a periodic worker [2] that is used to remove the expired reservations. This is used by the quota driver ``DbQuotaNoLockDriver`` (the default one).

When using WSGI, this worker is not launched.

[1]https://review.opendev.org/c/openstack/neutron/+/825521
[2]https://github.com/openstack/neutron/blob/0c4793ed2a3529cdf9f90eeea498e98cae71fd9f/neutron/worker.py#L31

Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
summary: - [WSGI] Missing periodic worker when using WSGI server
+ [WSGI] Missing periodic workers when using WSGI server
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/922090

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/922110

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/922182

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/922090
Committed: https://opendev.org/openstack/neutron/commit/cabe18dd79ea5144554697dba0a523a6f8dc42e7
Submitter: "Zuul (22348)"
Branch: master

commit cabe18dd79ea5144554697dba0a523a6f8dc42e7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jun 17 10:24:44 2024 +0000

    Set the Neutron server workers name

    The patch [1] defines the RpcWorker and RpcReportsWorker processes
    names. However, the parent class ``neutron_lib.worker.BaseWorker``
    init method is not reading the class variable defined in [1]. This
    patch is explictly passing the ``desc`` class name in the init method.

    [1]https://review.opendev.org/c/openstack/neutron/+/907712

    Closes-Bug: #2069581
    Change-Id: I50c2b0567ea10316ad06e6e6c1d01db8b9520e3e

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 25.0.0.0b1

This issue was fixed in the openstack/neutron 25.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/922110
Committed: https://opendev.org/openstack/neutron/commit/811f74d943aa902771dfb58a88553df099a44bc5
Submitter: "Zuul (22348)"
Branch: master

commit 811f74d943aa902771dfb58a88553df099a44bc5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jun 17 13:32:24 2024 +0000

    Add a new process to spawn the plugin services in the Neutron server

    When using the Neutron WSGI module, the plugin services (periodic
    workers created on demand in the ML2 plugin initialization) were not
    spawned.

    This patch adds a new service that should be spawned within the Neutron
    API processes, similar to the RPC server.

    Closes-Bug: #2069581
    Change-Id: Ia5376a68bfbcff4156800f550f28b59944b863c3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/923199

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/923500

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/922182
Reason: devnest patch tested

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/923199
Committed: https://opendev.org/openstack/neutron/commit/cc45ca03783dfc39d365c3755d35b16de5619a2b
Submitter: "Zuul (22348)"
Branch: master

commit cc45ca03783dfc39d365c3755d35b16de5619a2b
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Jun 29 17:25:20 2024 +0000

    Release note for ``neutron-periodic-workers`` process

    Related-Bug: #2069581
    Change-Id: I62d33908e0ff7d298172eca76b0e50e9de941bd6

summary: - [WSGI] Missing periodic workers when using WSGI server
+ [eventlet-deprecation][WSGI] Missing periodic workers when using WSGI
+ server
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/923711

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-tempest-plugin (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/923730

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/924317

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/923500
Committed: https://opendev.org/openstack/neutron/commit/d2e53f83f792e9fc7d6cd444bc35581d25e38a5f
Submitter: "Zuul (22348)"
Branch: master

commit d2e53f83f792e9fc7d6cd444bc35581d25e38a5f
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Jul 4 10:53:14 2024 +0000

    Limit the worker type in neutron-periodic-workers service

    The service "neutron-periodic-workers" is in charge of executing the
    ML2 plugin periodic workers (usually ``PeriodicWorker`` type). These
    workers have a worker_process_count=0.

    Before this patch, the method ``start_periodic_workers`` was also
    spawning other ML2 plugin workers, as the ML2/OVN ``MaintenanceWorker``,
    not expected to be running in this service.

    Closes-Bug: #2071920
    Related-Bug: #2069581
    Change-Id: Ic87ec5cc5037cab6eb0e24746a95ab4c8447870b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/neutron/+/923711
Committed: https://opendev.org/openstack/neutron/commit/19208ebdae49da690c4250358962f990bc707644
Submitter: "Zuul (22348)"
Branch: master

commit 19208ebdae49da690c4250358962f990bc707644
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 8 16:14:31 2024 +0000

    [WSGI] Move all OVS jobs to use WSGI API module

    All the ML2/OVS tempest jobs are now using the WSGI API
    module, instead of the eventlet server.

    Related-Bug: #2069581
    Topic: eventlet-deprecation
    Change-Id: I35d700885e6de0f1b92537789ae9819f8b21db0c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-tempest-plugin (master)

Reviewed: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/923730
Committed: https://opendev.org/openstack/neutron-tempest-plugin/commit/575840dad92a16ddd9be32a73f025c514bc01a2c
Submitter: "Zuul (22348)"
Branch: master

commit 575840dad92a16ddd9be32a73f025c514bc01a2c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 8 19:34:25 2024 +0000

    [WSGI] Move all OVS jobs to use WSGI API module

    All the ML2/OVS jobs in master branch (Dalmatian 2024.2) are now using
    the WSGI API module, instead of the eventlet server.

    Related-Bug: #2069581
    Topic: eventlet-deprecation
    Change-Id: Iff105f644459b56ece054bdefb294b1c6da143f5

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.