The ML2/OVN OVSDB maintenance job fails to handle properly user defined flavor routers gateway ports

[Miguel Lavalle]

The ML2/OVN OVSDB maintenance tasks check_redirect_type_router_gateway_ports and add_gw_port_info_to_logical_router_port fail when trying to process the gateway ports of user defined flavor routers:

May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics [None req-9bf768c3-df47-4d6f-9dd1-5b9960b50f0d None None] Failed to call periodic 'neutron.plugins.ml2.driver
s.ovn.mech_driver.ovsdb.maintenance.DBInconsistenciesPeriodics.add_gw_port_info_to_logical_router_port' (it runs every 600.00 seconds): AttributeError: 'NoneType' object has no attrib
ute 'ports'
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics Traceback (most recent call last):
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py", line 290, in run
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics work()
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py", line 64, in __call__
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics return self.callback(*self.args, **self.kwargs)
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py", line 178, in decorator
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics return f(*args, **kwargs)
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 67, in dec
orator
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics return f(self, *args, **kwargs)
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 943, in add_gw_port_info_to_logical_router_port
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics for lrp in ovn_lr.ports:
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics AttributeError: 'NoneType' object has no attribute 'ports'
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics
May 03 22:50:17 central neutron-server[1035740]: DEBUG futurist.periodics [None req-9bf768c3-df47-4d6f-9dd1-5b9960b50f0d None None] Submitting periodic callback 'neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance.DBInconsistenciesPeriodics.check_redirect_type_router_gateway_ports' {{(pid=1035740) _process_scheduled /opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py:638}}
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics [None req-9bf768c3-df47-4d6f-9dd1-5b9960b50f0d None None] Failed to call periodic 'neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance.DBInconsistenciesPeriodics.check_redirect_type_router_gateway_ports' (it runs every 600.00 seconds): AttributeError: 'NoneType' object has no attribute 'options'
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics Traceback (most recent call last):
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py", line 290, in run
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics work()
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py", line 64, in __call__
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics return self.callback(*self.args, **self.kwargs)
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py", line 178, in decorator
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics return f(*args, **kwargs)
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 67, in decorator
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics return f(self, *args, **kwargs)
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 694, in check_redirect_type_router_gateway_ports
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics redirect_value = lrp.options.get(
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics AttributeError: 'NoneType' object has no attribute 'options'
May 03 22:50:17 central neutron-server[1035740]: ERROR futurist.periodics
May 03 22:50:17 central neutron-server[1035740]: DEBUG futurist.periodics [None req-9bf768c3-df47-4d6f-9dd1-5b9960b50f0d None None] Submitting periodic callback 'neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance.DBInconsistenciesPeriodics.check_for_inconsistencies' {{(pid=1035740) _process_scheduled /opt/stack/data/venv/lib/python3.10/site-packages/futurist/periodics.py:638}}

The tasks should ignore the gateway ports of user defined flavor routers, because they don't exist in the OVN database.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/918151