The HA flag of user defined flavos routers is always set to true

[Miguel Lavalle]

Since [1] was merged, non HA user defined flavor routers cannot be created.

100% reproducible following these steps:

1) Create a non high availability flavor profile:

$ openstack network flavor profile create --description "User-defined router flavor profile" --enable --driver neutron.services.ovn_l3.service_providers.user_defined.UserDefined
+-------------+--------------------------------------------------------------------+
| Field | Value |
+-------------+--------------------------------------------------------------------+
| description | User-defined router flavor profile |
| driver | neutron.services.ovn_l3.service_providers.user_defined.UserDefined |
| enabled | True |
| id | 04f95202-a0ce-42ca-b76d-1b1678b0caf5 |
| meta_info | |
| project_id | None |
+-------------+--------------------------------------------------------------------+

2) Create a router flavor and associate to the profile:

$ openstack network flavor create --service-type L3_ROUTER_NAT --description "User-defined flavor for routers in the L3 OVN plugin" user-defined-router-flavor
+---------------------+------------------------------------------------------+
| Field | Value |
+---------------------+------------------------------------------------------+
| description | User-defined flavor for routers in the L3 OVN plugin |
| enabled | True |
| id | a350b61e-c5b5-42d1-a95d-73215065eb78 |
| name | user-defined-router-flavor |
| service_profile_ids | [] |
| service_type | L3_ROUTER_NAT |
+---------------------+------------------------------------------------------+

$ openstack network flavor add profile user-defined-router-flavor 04f95202-a0ce-42ca-b76d-1b1678b0caf5

3) Attempt to create a non-HA user defined flavor router:

$ openstack router create router-of-user-defined-flavor --external-gateway public --flavor-id a350b61e-c5b5-42d1-a95d-73215065eb78 -c ha
+-------+-------+
| Field | Value |
+-------+-------+
| ha | True |
+-------+-------+

The expected result is:

+-------+-------+
| Field | Value |
+-------+-------+
| ha | False |
+-------+-------+

[1] https://review.opendev.org/c/openstack/neutron/+/910889

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/913276

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/913276
Committed: https://opendev.org/openstack/neutron/commit/26ff51bf05dd8b61d96489f6b459e8f62f855823
Submitter: "Zuul (22348)"
Branch: master

commit 26ff51bf05dd8b61d96489f6b459e8f62f855823
Author: Miguel Lavalle <email address hidden>
Date: Thu Mar 14 18:09:28 2024 -0500

    Fix making all user defined flavor routers HA

    Since [1] was merged, user defined flavor routers with the HA
    attribute set to False cannot be created. This change fixes
    it.

    Closes-Bug: #2057983

    [1] https://review.opendev.org/c/openstack/neutron/+/910889

    Change-Id: Ic72979cfe535c1bb8cba77fb82a380c167509060

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/neutron/+/913735

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/913735
Committed: https://opendev.org/openstack/neutron/commit/fed96541c778768b279f1116f7b330aa9e4ab491
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit fed96541c778768b279f1116f7b330aa9e4ab491
Author: Miguel Lavalle <email address hidden>
Date: Thu Mar 14 18:09:28 2024 -0500

    Fix making all user defined flavor routers HA

    Since [1] was merged, user defined flavor routers with the HA
    attribute set to False cannot be created. This change fixes
    it.

    Closes-Bug: #2057983

    [1] https://review.opendev.org/c/openstack/neutron/+/910889

    Change-Id: Ic72979cfe535c1bb8cba77fb82a380c167509060
    (cherry picked from commit 26ff51bf05dd8b61d96489f6b459e8f62f855823)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 24.0.0.0rc2 release candidate.