multisegments: cleaning DHCP process for segment 0 should happen first

[Sahid Orentino]

With the new support of multi-segments some code has been added to clean old dhcp setup for a network. that clean should happen first and clean segment index == 0.

As list of segment for a given network does not come ordered by segment index, in the process we can be in that situation of having network setup for multi index 1 coming before index 0 which means it will be destroyed by the clean resulting a missing setup.

[Lajos Katona (lajos-katona)]

Related patch: https://review.opendev.org/c/openstack/neutron/+/905617

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/905617
Committed: https://opendev.org/openstack/neutron/commit/5453c92a2e777b9a41989cc21d6064ffe4711e8d
Submitter: "Zuul (22348)"
Branch: master

commit 5453c92a2e777b9a41989cc21d6064ffe4711e8d
Author: Sahid Orentino Ferdjaoui <email address hidden>
Date: Mon Jan 15 17:11:23 2024 +0100

    dhcp: ensure that cleaning DHCP process with one segment happens first

    Previously, the code used to clean up old DHCP processes for a network
    before creating new ones supporting multiple segments per network
    could potentially not be executed first. Since disabling applies to
    cleaning the namespace, this could have led to the network setup being
    destroyed after being done.

    This change moves the part that cleans up the old DHCP setup to ensure
    it is executed first.

    Closes-bug: #2049615
    Signed-off-by: Sahid Orentino Ferdjaoui <email address hidden>
    Change-Id: Iecdb2d81ee077c9b9057d0708c5c88e159970039