neutron

Restore the device namespace if "set_netns" fails

Bug #2049590 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

If the method ``IpLinkCommand.set_netns`` [1] fails, the device namespace should keep the previous value.

[1]https://github.com/openstack/neutron/blob/12115302944293b7d6b022f5acb68fe9c649a53e/neutron/agent/linux/ip_lib.py#L479

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/905836

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/906855

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/906856

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/905836
Committed: https://opendev.org/openstack/neutron/commit/e234a7aeab72958a74e5d9540253d48aa6915816
Submitter: "Zuul (22348)"
Branch: master

commit e234a7aeab72958a74e5d9540253d48aa6915816
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jan 16 02:36:27 2024 +0000

    If method ``set_netns`` fails, restore previous device namespace

    If the ``IpLinkCommand.set_netns`` fails, the method restores the
    previous device namespace before raising the exception.

    Closes-Bug: #2049590
    Change-Id: I73b36ef161441b52922d888c11a144eafe8a7ed0

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/906856
Committed: https://opendev.org/openstack/neutron/commit/2c797b107b7360e05b4f79980d4c4e433d4e669e
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 2c797b107b7360e05b4f79980d4c4e433d4e669e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jan 16 02:36:27 2024 +0000

    If method ``set_netns`` fails, restore previous device namespace

    If the ``IpLinkCommand.set_netns`` fails, the method restores the
    previous device namespace before raising the exception.

    Closes-Bug: #2049590
    Change-Id: I73b36ef161441b52922d888c11a144eafe8a7ed0
    (cherry picked from commit e234a7aeab72958a74e5d9540253d48aa6915816)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/906855
Committed: https://opendev.org/openstack/neutron/commit/3eddcd970d9cfa19f141d9391df0208a29593589
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 3eddcd970d9cfa19f141d9391df0208a29593589
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Jan 16 02:36:27 2024 +0000

    If method ``set_netns`` fails, restore previous device namespace

    If the ``IpLinkCommand.set_netns`` fails, the method restores the
    previous device namespace before raising the exception.

    Closes-Bug: #2049590
    Change-Id: I73b36ef161441b52922d888c11a144eafe8a7ed0
    (cherry picked from commit e234a7aeab72958a74e5d9540253d48aa6915816)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 24.0.0.0rc1

This issue was fixed in the openstack/neutron 24.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.