VM fails to contact metadata during live-migration

[Jakub Libosvar]

There is a short outage of metadata service while a VM is live migrating to another node.

Steps to Reproduce:
1. create a VM
2. live-migrate it to another compute while querying the metadata service from inside of the vm

Bugzilla reference: https://bugzilla.redhat.com/show_bug.cgi?id=2236159

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/896163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/896163
Committed: https://opendev.org/openstack/neutron/commit/6801589510242affc78497660d34377603774074
Submitter: "Zuul (22348)"
Branch: master

commit 6801589510242affc78497660d34377603774074
Author: Jakub Libosvar <email address hidden>
Date: Thu Sep 21 19:40:36 2023 +0000

    ovn-metadata: Refactor events

    The agent had multiple events matching the same event type and calling
    the same run() method. Also the same things as in match_fn() were
    checked later again in run() method. This patch squashes the events, as
    a result there are only Port Binding Update and Port Binding Delete
    events that either provision or teardown the resources.

    Related bug: #2036118

    Change-Id: I13f4e95eacb3cbdd3170f9707b2310bfae13a2bc
    Signed-off-by: Jakub Libosvar <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/895402
Committed: https://opendev.org/openstack/neutron/commit/3ec7f96cbb0571c401406781562160db75b3b9f5
Submitter: "Zuul (22348)"
Branch: master

commit 3ec7f96cbb0571c401406781562160db75b3b9f5
Author: Jakub Libosvar <email address hidden>
Date: Thu Sep 21 21:06:41 2023 +0000

    ovn: Spawn metadata resources on additional chassis event

    Since the additional_chassis column [1] is used during the live
    migration in order to optimize the VM network timeout, we can also use
    this to minimize downtime for the metadata service. The patch adds
    additional match to when new Port Binding is introduced to the chassis
    associated with a node. This triggers the provisioning of metadata
    resources a lot earlier in the process, while the VM is still in paused
    state.

    [1]
    https://opendev.org/openstack/neutron/commit/35fade3b5fbe898885338cbe74843e903d4e8a87

    Closes-bug: #2036118
    Change-Id: I66fa3c541db54c5f57404681f30b141fe8dad84a
    Signed-off-by: Jakub Libosvar <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/902155

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/902156

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Lucas Alvares Gomes <email address hidden>" on branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/902156

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/903509

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Lucas Alvares Gomes <email address hidden>" on branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/903509

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/902155
Committed: https://opendev.org/openstack/neutron/commit/81c78e29299d8b26645c99e2fe3dba86bd6e2e4a
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 81c78e29299d8b26645c99e2fe3dba86bd6e2e4a
Author: Jakub Libosvar <email address hidden>
Date: Thu Sep 21 19:40:36 2023 +0000

    ovn-metadata: Refactor events

    The agent had multiple events matching the same event type and calling
    the same run() method. Also the same things as in match_fn() were
    checked later again in run() method. This patch squashes the events, as
    a result there are only Port Binding Update and Port Binding Delete
    events that either provision or teardown the resources.

    Related bug: #2036118

    Change-Id: I13f4e95eacb3cbdd3170f9707b2310bfae13a2bc
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 6801589510242affc78497660d34377603774074)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/903509
Committed: https://opendev.org/openstack/neutron/commit/62051588314b66ba884e5df1cf2e6f39dfd50506
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 62051588314b66ba884e5df1cf2e6f39dfd50506
Author: Jakub Libosvar <email address hidden>
Date: Thu Sep 21 19:40:36 2023 +0000

    ovn-metadata: Refactor events

    The agent had multiple events matching the same event type and calling
    the same run() method. Also the same things as in match_fn() were
    checked later again in run() method. This patch squashes the events, as
    a result there are only Port Binding Update and Port Binding Delete
    events that either provision or teardown the resources.

    Related bug: #2036118

    Change-Id: I13f4e95eacb3cbdd3170f9707b2310bfae13a2bc
    Signed-off-by: Jakub Libosvar <email address hidden>
    (cherry picked from commit 6801589510242affc78497660d34377603774074)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: unmaintained/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/926655

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Terry Wilson <email address hidden>" on branch: unmaintained/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/926655
Reason: Shouldn't need this with new port binding patch