[HA] "neutron-dynamic-routing" HA unittest failing

[Joel Capitao]

"neutron_dynamic_routing.tests.unit.db.test_bgp_db.Ml2BgpTests.test_ha_router_fips_has_no_next_hop_to_fip_agent_gateway" is currently failing.
This issue appears since https://review.opendev.org/c/openstack/neutron/+/881742 was merged.

DEBUG: ==============================
DEBUG: Failed 1 tests - output below:
DEBUG: ==============================
DEBUG: neutron_dynamic_routing.tests.unit.db.test_bgp_db.Ml2BgpTests.test_ha_router_fips_has_no_next_hop_to_fip_agent_gateway
DEBUG: ----------------------------------------------------------------------------------------------------------------------
DEBUG: Captured traceback:
DEBUG: ~~~~~~~~~~~~~~~~~~~
DEBUG: Traceback (most recent call last):
DEBUG: File "/usr/lib/python3.9/site-packages/neutron/tests/base.py", line 178, in func
DEBUG: return f(self, *args, **kwargs)
DEBUG: File "/builddir/build/BUILD/neutron-dynamic-routing-22.1.0.dev11/neutron_dynamic_routing/tests/unit/db/test_bgp_db.py", line 1277, in test_ha_router_fips_has_no_next_hop_to_fip_agent_gateway
DEBUG: self._test_legacy_router_fips_next_hop(router_ha=True)
DEBUG: File "/builddir/build/BUILD/neutron-dynamic-routing-22.1.0.dev11/neutron_dynamic_routing/tests/unit/db/test_bgp_db.py", line 1240, in _test_legacy_router_fips_next_hop
DEBUG: with self.router_with_external_and_tenant_networks(
DEBUG: File "/usr/lib64/python3.9/contextlib.py", line 119, in __enter__
DEBUG: return next(self.gen)
DEBUG: File "/builddir/build/BUILD/neutron-dynamic-routing-22.1.0.dev11/neutron_dynamic_routing/tests/unit/db/test_bgp_db.py", line 164, in router_with_external_and_tenant_networks
DEBUG: with self.router(external_gateway_info=ext_gw_info,
DEBUG: File "/usr/lib64/python3.9/contextlib.py", line 119, in __enter__
DEBUG: return next(self.gen)
DEBUG: File "/builddir/build/BUILD/neutron-dynamic-routing-22.1.0.dev11/neutron_dynamic_routing/tests/unit/db/test_bgp_db.py", line 120, in router
DEBUG: router = self.l3plugin.create_router(self.context, request)
DEBUG: File "/usr/lib/python3.9/site-packages/neutron/db/l3_db.py", line 2202, in create_router
DEBUG: router_dict = super(L3_NAT_db_mixin, self).create_router(context,
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/db/api.py", line 223, in wrapped
DEBUG: return f_with_retry(*args, **kwargs,
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/db/api.py", line 139, in wrapped
DEBUG: setattr(e, '_RETRY_EXCEEDED', True)
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 227, in __exit__
DEBUG: self.force_reraise()
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 200, in force_reraise
DEBUG: raise self.value
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/db/api.py", line 135, in wrapped
DEBUG: return f(*args, **kwargs)
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_db/api.py", line 154, in wrapper
DEBUG: ectxt.value = e.inner_exc
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 227, in __exit__
DEBUG: self.force_reraise()
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 200, in force_reraise
DEBUG: raise self.value
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_db/api.py", line 142, in wrapper
DEBUG: return f(*args, **kwargs)
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/db/api.py", line 187, in wrapped
DEBUG: context_reference.session.rollback()
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 227, in __exit__
DEBUG: self.force_reraise()
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 200, in force_reraise
DEBUG: raise self.value
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/db/api.py", line 181, in wrapped
DEBUG: return f(*dup_args, **dup_kwargs)
DEBUG: File "/usr/lib/python3.9/site-packages/neutron/db/l3_db.py", line 304, in create_router
DEBUG: router_db, _unused = db_utils.safe_creation(context, create,
DEBUG: File "/usr/lib/python3.9/site-packages/neutron/db/_utils.py", line 67, in safe_creation
DEBUG: obj = create_fn()
DEBUG: File "/usr/lib/python3.9/site-packages/neutron/db/l3_db.py", line 244, in _create_router_db
DEBUG: registry.publish(resources.ROUTER, events.BEFORE_CREATE, self,
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/callbacks/registry.py", line 54, in publish
DEBUG: _get_callback_manager().publish(resource, event, trigger, payload=payload)
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/db/utils.py", line 109, in _wrapped
DEBUG: raise db_exc.RetryRequest(e)
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 227, in __exit__
DEBUG: self.force_reraise()
DEBUG: File "/usr/lib/python3.9/site-packages/oslo_utils/excutils.py", line 200, in force_reraise
DEBUG: raise self.value
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/db/utils.py", line 104, in _wrapped
DEBUG: return function(*args, **kwargs)
DEBUG: File "/usr/lib/python3.9/site-packages/neutron_lib/callbacks/manager.py", line 157, in publish
DEBUG: raise exceptions.CallbackFailure(errors=errors)
DEBUG: neutron_lib.callbacks.exceptions.CallbackFailure: Callback neutron_dynamic_routing.tests.unit.db.test_bgp_db.L3_HA_NAT_db_mixin._before_router_create_handler-4715705 failed with "Unrecognized attribute(s) 'ha'"

[Joel Capitao (jcapitao)]

I pushed a DNM patch to reproduce the issue in CI https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/893192

[Brian Haley (brian-haley)]

Seems like a duplicate of https://bugs.launchpad.net/neutron/+bug/2033493 ?

[Dr. Jens Harbott (j-harbott)]

@Brian, no this is a unit test failure, where latest neutron is getting used. I suspect https://review.opendev.org/c/openstack/neutron/+/881742 to be the cause, which got merged yesterday.

[Joel Capitao (jcapitao)]

At RDO, the bug has appeared since https://review.opendev.org/c/openstack/neutron/+/881742 was merged.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Patch proposed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/893189

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/893189
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/f7baab86ac94bd53bae10e25ea08c4f1b93b9e31
Submitter: "Zuul (22348)"
Branch: master

commit f7baab86ac94bd53bae10e25ea08c4f1b93b9e31
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Aug 30 13:52:36 2023 +0000

    Bump Neutron to 23.0.0.0b3

    That syncs the Neutron code with the latest neutron-lib version
    released (3.8.0).

    This patch also adds the "network.ha" definition extension to
    the tests core plugin.

    NOTE: both LP bugs must be fixed in one patch to fix the unit
    tests CI job.

    Closes-Bug: #2033493
    Closes-Bug: #2033508
    Change-Id: Ie22d9bcb943205e20380b92dc33d48f398a86470

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 23.0.0.0rc1 release candidate.