OVN metadata agent keeps restarting

[Miro Tomaska]

As per Red Hat bug#2229779 [1] . The ovn-metadata-agent keeps restarting when it encounters an error spawing haproxy process for a network(datapat). This renders the agent unusable. Agent should handle process exceptions and continue to function.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2229779

[Brian Haley (brian-haley)]

https://review.opendev.org/c/openstack/neutron/+/890986

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/893775

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/893776

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/893777

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/893778

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/893779

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/893775
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/890986
Committed: https://opendev.org/openstack/neutron/commit/ed0515737be75745933f4994b5e6b652f9e0a2be
Submitter: "Zuul (22348)"
Branch: master

commit ed0515737be75745933f4994b5e6b652f9e0a2be
Author: Miro Tomaska <email address hidden>
Date: Wed Aug 9 17:34:34 2023 -0400

    Metadata: handle process exceptions

    Both metadata agents (OVN and non-OVN) should handle
    process exceptions when spawning haproxy processes
    such that the agent can continue its operation for
    other haproxy processes.

    Closes-Bug: #2033305
    Change-Id: I6da1b135c83ecfc41ec91e907ebf8500325a7a80

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/902677

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/902677
Committed: https://opendev.org/openstack/neutron/commit/14a830fb36dcbd7793cb766c68945660a622a37e
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 14a830fb36dcbd7793cb766c68945660a622a37e
Author: Miro Tomaska <email address hidden>
Date: Wed Aug 9 17:34:34 2023 -0400

    Metadata: handle process exceptions

    Both metadata agents (OVN and non-OVN) should handle
    process exceptions when spawning haproxy processes
    such that the agent can continue its operation for
    other haproxy processes.

    Closes-Bug: #2033305
    Change-Id: I6da1b135c83ecfc41ec91e907ebf8500325a7a80
    (cherry picked from commit ed0515737be75745933f4994b5e6b652f9e0a2be)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893776
Committed: https://opendev.org/openstack/neutron/commit/4698dd899fa149088160372b6f2efcd3ce973cbb
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 4698dd899fa149088160372b6f2efcd3ce973cbb
Author: Miro Tomaska <email address hidden>
Date: Wed Aug 9 17:34:34 2023 -0400

    Metadata: handle process exceptions

    Both metadata agents (OVN and non-OVN) should handle
    process exceptions when spawning haproxy processes
    such that the agent can continue its operation for
    other haproxy processes.

    Note:
    neutron/tests/unit/agent/dhcp/test_agent.py#L836
    Added `mock.call.get_pid_file_name()` to the expected
    list of process calls. This call was removed in stable/2031.1
    and later.
    https://review.opendev.org/c/openstack/neutron/+/903149

    Closes-Bug: #2033305
    Change-Id: I6da1b135c83ecfc41ec91e907ebf8500325a7a80
    (cherry picked from commit ed0515737be75745933f4994b5e6b652f9e0a2be)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893777
Committed: https://opendev.org/openstack/neutron/commit/824a8257a88d7192ecd4a5efdcd1dba46d63d82b
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 824a8257a88d7192ecd4a5efdcd1dba46d63d82b
Author: Miro Tomaska <email address hidden>
Date: Wed Aug 9 17:34:34 2023 -0400

    Metadata: handle process exceptions

    Both metadata agents (OVN and non-OVN) should handle
    process exceptions when spawning haproxy processes
    such that the agent can continue its operation for
    other haproxy processes.

    Closes-Bug: #2033305
    Change-Id: I6da1b135c83ecfc41ec91e907ebf8500325a7a80
    (cherry picked from commit 4698dd899fa149088160372b6f2efcd3ce973cbb)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893778
Committed: https://opendev.org/openstack/neutron/commit/3ed088bc4ef5403aec6471e552fb1d4b15a49165
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 3ed088bc4ef5403aec6471e552fb1d4b15a49165
Author: Miro Tomaska <email address hidden>
Date: Wed Aug 9 17:34:34 2023 -0400

    Metadata: handle process exceptions

    Both metadata agents (OVN and non-OVN) should handle
    process exceptions when spawning haproxy processes
    such that the agent can continue its operation for
    other haproxy processes.

    Closes-Bug: #2033305
    Change-Id: I6da1b135c83ecfc41ec91e907ebf8500325a7a80
    (cherry picked from commit 824a8257a88d7192ecd4a5efdcd1dba46d63d82b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893779
Committed: https://opendev.org/openstack/neutron/commit/5ead8779f8939658985f54e7cf133c37cd15fc4f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5ead8779f8939658985f54e7cf133c37cd15fc4f
Author: Miro Tomaska <email address hidden>
Date: Wed Aug 9 17:34:34 2023 -0400

    Metadata: handle process exceptions

    Both metadata agents (OVN and non-OVN) should handle
    process exceptions when spawning haproxy processes
    such that the agent can continue its operation for
    other haproxy processes.

    Closes-Bug: #2033305
    Change-Id: I6da1b135c83ecfc41ec91e907ebf8500325a7a80
    (cherry picked from commit 3ed088bc4ef5403aec6471e552fb1d4b15a49165)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/893775
Committed: https://opendev.org/openstack/neutron/commit/63c16672a5ff3a82607bf1912bc51b5db21a1571
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 63c16672a5ff3a82607bf1912bc51b5db21a1571
Author: Miro Tomaska <email address hidden>
Date: Wed Aug 9 17:34:34 2023 -0400

    Metadata: handle process exceptions

    Both metadata agents (OVN and non-OVN) should handle
    process exceptions when spawning haproxy processes
    such that the agent can continue its operation for
    other haproxy processes.

    Closes-Bug: #2033305
    Change-Id: I6da1b135c83ecfc41ec91e907ebf8500325a7a80
    (cherry picked from commit ed0515737be75745933f4994b5e6b652f9e0a2be)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron yoga-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron xena-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.2.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.2.0 release.