neutron

OVN Metadata agent tearsdown all namespaces on restart

Bug #2031184 reported by Miro Tomaska
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Miro Tomaska

Bug Description

I came accross this bug while looking at some other thing(metadata haproxies processes). The sync function in the ovn metadata agent retrieves metadata namespaces based on OVN datapath uuid[1] but the check for unused namespaces[2] is peformed on namespaces based on network uuid. The end result is that ovn agent will always teardown all namespaces and recreate them on ovn metadata restart.

[1] https://opendev.org/openstack/neutron/src/commit/3930b9f5c54971db3c7c30094baf6c128bc60043/neutron/agent/ovn/metadata/agent.py#L399
[2] https://opendev.org/openstack/neutron/src/commit/3930b9f5c54971db3c7c30094baf6c128bc60043/neutron/agent/ovn/metadata/agent.py#L403

Miro Tomaska (mtomaska)
Changed in neutron:
importance: Undecided → High
assignee: nobody → Miro Tomaska (mtomaska)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/891232

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/891232
Committed: https://opendev.org/openstack/neutron/commit/87b2f34a98349012ecceed0e54dc766d36024685
Submitter: "Zuul (22348)"
Branch: master

commit 87b2f34a98349012ecceed0e54dc766d36024685
Author: Miro Tomaska <email address hidden>
Date: Thu Aug 17 11:16:19 2023 -0400

    Fix ovn-metadata agent sync of unused namespaces

    metadata_namespaces contained datapath uuid and not the
    neutron network uuid. This broke the logic for namespaces clean up,
    resulting in all namespaces getting torn down and recreated at each
    metadata agent sync.

    Closes-Bug: #2031184
    Change-Id: I58dd1973b73aa006234e7b808b6a3f357182a4b3

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/892748

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/892749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/892750

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/892751

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/892752

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892748
Committed: https://opendev.org/openstack/neutron/commit/be0cb0690e252e3ef8e9ab0698fb2707d781b548
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit be0cb0690e252e3ef8e9ab0698fb2707d781b548
Author: Miro Tomaska <email address hidden>
Date: Thu Aug 17 11:16:19 2023 -0400

    Fix ovn-metadata agent sync of unused namespaces

    metadata_namespaces contained datapath uuid and not the
    neutron network uuid. This broke the logic for namespaces clean up,
    resulting in all namespaces getting torn down and recreated at each
    metadata agent sync.

    Closes-Bug: #2031184
    Change-Id: I58dd1973b73aa006234e7b808b6a3f357182a4b3
    (cherry picked from commit 87b2f34a98349012ecceed0e54dc766d36024685)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892749
Committed: https://opendev.org/openstack/neutron/commit/9a537fdf6cdd38cf910acb41a5cb6d27f7f68a73
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 9a537fdf6cdd38cf910acb41a5cb6d27f7f68a73
Author: Miro Tomaska <email address hidden>
Date: Thu Aug 17 11:16:19 2023 -0400

    Fix ovn-metadata agent sync of unused namespaces

    metadata_namespaces contained datapath uuid and not the
    neutron network uuid. This broke the logic for namespaces clean up,
    resulting in all namespaces getting torn down and recreated at each
    metadata agent sync.

    Closes-Bug: #2031184
    Change-Id: I58dd1973b73aa006234e7b808b6a3f357182a4b3
    (cherry picked from commit 87b2f34a98349012ecceed0e54dc766d36024685)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892750
Committed: https://opendev.org/openstack/neutron/commit/7034f4cf73723d129b950d370b167c1c576d559c
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 7034f4cf73723d129b950d370b167c1c576d559c
Author: Miro Tomaska <email address hidden>
Date: Thu Aug 17 11:16:19 2023 -0400

    Fix ovn-metadata agent sync of unused namespaces

    metadata_namespaces contained datapath uuid and not the
    neutron network uuid. This broke the logic for namespaces clean up,
    resulting in all namespaces getting torn down and recreated at each
    metadata agent sync.

    Closes-Bug: #2031184
    Change-Id: I58dd1973b73aa006234e7b808b6a3f357182a4b3
    (cherry picked from commit 87b2f34a98349012ecceed0e54dc766d36024685)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892751
Committed: https://opendev.org/openstack/neutron/commit/41df9488a8672e4502f553bbd5c65ac4f4a9e6eb
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 41df9488a8672e4502f553bbd5c65ac4f4a9e6eb
Author: Miro Tomaska <email address hidden>
Date: Thu Aug 17 11:16:19 2023 -0400

    Fix ovn-metadata agent sync of unused namespaces

    metadata_namespaces contained datapath uuid and not the
    neutron network uuid. This broke the logic for namespaces clean up,
    resulting in all namespaces getting torn down and recreated at each
    metadata agent sync.

    Closes-Bug: #2031184
    Change-Id: I58dd1973b73aa006234e7b808b6a3f357182a4b3
    (cherry picked from commit 87b2f34a98349012ecceed0e54dc766d36024685)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892752
Committed: https://opendev.org/openstack/neutron/commit/326463f2fd1e04b3f8af6b2e11a2ac9e1fa13240
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 326463f2fd1e04b3f8af6b2e11a2ac9e1fa13240
Author: Miro Tomaska <email address hidden>
Date: Thu Aug 17 11:16:19 2023 -0400

    Fix ovn-metadata agent sync of unused namespaces

    metadata_namespaces contained datapath uuid and not the
    neutron network uuid. This broke the logic for namespaces clean up,
    resulting in all namespaces getting torn down and recreated at each
    metadata agent sync.

    Closes-Bug: #2031184
    Change-Id: I58dd1973b73aa006234e7b808b6a3f357182a4b3
    (cherry picked from commit 87b2f34a98349012ecceed0e54dc766d36024685)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.0.0.0b3

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.1.0

This issue was fixed in the openstack/neutron 22.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.5.0

This issue was fixed in the openstack/neutron 20.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.2.0

This issue was fixed in the openstack/neutron 21.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron xena-eom

This issue was fixed in the openstack/neutron xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.