[ovn-octavia-provider] FIP not included into LogicalSwitchPortUpdate event handler method

Bug #2028161 reported by Fernando Royo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Fernando Royo

Bug Description

When a LogicalSwitchPortUpdate event is triggered after removing
FIP from LB VIP, the event received include the port affected,
but the FIP related is not passing to the handler method.

Including the FIP would help on decide if it is an association or and
disassociation action and also help to search the related objects
to be updated/deleted.

Changed in neutron:
assignee: nobody → Fernando Royo (froyoredhat)
Changed in neutron:
status: New → In Progress
Revision history for this message
Bence Romsics (bence-romsics) wrote :
Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/889097
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/46a4ae40bb0a3964438a3e38d888b192205b37ee
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 46a4ae40bb0a3964438a3e38d888b192205b37ee
Author: Fernando Royo <email address hidden>
Date: Wed Jul 19 12:50:09 2023 +0200

    Add FIP on LogicalSwitchPortUpdate event

    When a LogicalSwitchPortUpdate event is triggered after removing
    FIP from LB VIP, the event received include the port affected,
    but the FIP related is not passing to the handler method.

    This patch includes the FIP into the info passed to the handler
    method, simplifying the current handler logic and providing
    future support for the new multi-vip feature. Also added a match
    for only manage events including external_id updates.

    Closes-Bug: #2028161
    Change-Id: Ibee3906e8e9575fba7811e989e3e111a026ce45b
    (cherry picked from commit e9a55cd2b6eca09e14a18212d8d537eaa7ac17d7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/889099
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/74baf1a9e3c37b9a09ab9c7dcf6fc9cd051523b4
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 74baf1a9e3c37b9a09ab9c7dcf6fc9cd051523b4
Author: Fernando Royo <email address hidden>
Date: Wed Jul 19 12:50:09 2023 +0200

    Add FIP on LogicalSwitchPortUpdate event

    When a LogicalSwitchPortUpdate event is triggered after removing
    FIP from LB VIP, the event received include the port affected,
    but the FIP related is not passing to the handler method.

    This patch includes the FIP into the info passed to the handler
    method, simplifying the current handler logic and providing
    future support for the new multi-vip feature. Also added a match
    for only manage events including external_id updates.

    Closes-Bug: #2028161
    Change-Id: Ibee3906e8e9575fba7811e989e3e111a026ce45b
    (cherry picked from commit e9a55cd2b6eca09e14a18212d8d537eaa7ac17d7)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/889100
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/be3d65de7b7b30aad65a9244523d25ab67f18103
Submitter: "Zuul (22348)"
Branch: stable/xena

commit be3d65de7b7b30aad65a9244523d25ab67f18103
Author: Fernando Royo <email address hidden>
Date: Wed Jul 19 12:50:09 2023 +0200

    Add FIP on LogicalSwitchPortUpdate event

    When a LogicalSwitchPortUpdate event is triggered after removing
    FIP from LB VIP, the event received include the port affected,
    but the FIP related is not passing to the handler method.

    This patch includes the FIP into the info passed to the handler
    method, simplifying the current handler logic and providing
    future support for the new multi-vip feature. Also added a match
    for only manage events including external_id updates.

    Closes-Bug: #2028161
    Change-Id: Ibee3906e8e9575fba7811e989e3e111a026ce45b
    (cherry picked from commit e9a55cd2b6eca09e14a18212d8d537eaa7ac17d7)

tags: added: in-stable-xena
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/889101
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/4e00807ba9227172bd4b0376c4eed94a725a1a2a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4e00807ba9227172bd4b0376c4eed94a725a1a2a
Author: Fernando Royo <email address hidden>
Date: Wed Jul 19 12:50:09 2023 +0200

    Add FIP on LogicalSwitchPortUpdate event

    When a LogicalSwitchPortUpdate event is triggered after removing
    FIP from LB VIP, the event received include the port affected,
    but the FIP related is not passing to the handler method.

    This patch includes the FIP into the info passed to the handler
    method, simplifying the current handler logic and providing
    future support for the new multi-vip feature. Also added a match
    for only manage events including external_id updates.

    Closes-Bug: #2028161
    Change-Id: Ibee3906e8e9575fba7811e989e3e111a026ce45b
    (cherry picked from commit e9a55cd2b6eca09e14a18212d8d537eaa7ac17d7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/889098
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/eaba2f304963456ca5afe30cd6acb3d1e2083198
Submitter: "Zuul (22348)"
Branch: stable/zed

commit eaba2f304963456ca5afe30cd6acb3d1e2083198
Author: Fernando Royo <email address hidden>
Date: Wed Jul 19 12:50:09 2023 +0200

    Add FIP on LogicalSwitchPortUpdate event

    When a LogicalSwitchPortUpdate event is triggered after removing
    FIP from LB VIP, the event received include the port affected,
    but the FIP related is not passing to the handler method.

    This patch includes the FIP into the info passed to the handler
    method, simplifying the current handler logic and providing
    future support for the new multi-vip feature. Also added a match
    for only manage events including external_id updates.

    Closes-Bug: #2028161
    Change-Id: Ibee3906e8e9575fba7811e989e3e111a026ce45b
    (cherry picked from commit e9a55cd2b6eca09e14a18212d8d537eaa7ac17d7)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 5.0.0.0rc1

This issue was fixed in the openstack/ovn-octavia-provider 5.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider yoga-eom

This issue was fixed in the openstack/ovn-octavia-provider yoga-eom release.

Changed in neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.