[OVN] Disable LSP_OPTIONS_MCAST_FLOOD_REPORTS for LSPs

[Lucas Alvares Gomes]

Reported at https://bugzilla.redhat.com/show_bug.cgi?id=2219405

Enabling the mcast_flood_reports for ports from other types other than "localnet" was a workaround for a problem in core OVN that is now fixed (see [0]).

Leaving mcast_flood_reports enabled is now overflowing the number of actions in the table 38 of OVN. So we should disable that in ML2/OVN.

[0] https://github.com/openstack/neutron/blob/b92d133de66411b9444855cc97480891d7d7b7b2/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L369-L375

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Patch proposed: https://review.opendev.org/c/openstack/neutron/+/888127

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/888127
Committed: https://opendev.org/openstack/neutron/commit/06dbc5227b9208887bab9bc6623098c80156f36d
Submitter: "Zuul (22348)"
Branch: master

commit 06dbc5227b9208887bab9bc6623098c80156f36d
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Jul 11 11:29:13 2023 +0100

    [OVN] Disable the mcast_flood_reports option for LSPs

    The mcast_flood_reports option was being enabled on LSPs as a workaround
    for a problem in core OVN. The issue in core OVN has been fixed and this
    workaround is now causing an increase in the number of actions on the
    table 38 of OVN (at the risk of hitting a size limit).

    This patch disables the mcast_flood_reports option on newer versions of
    OVN while keeping the backward compatibility with the old ones.

    Since the fix in core OVN does not expose any information to the CMS to
    tell us that the issue is fixed this patch uses the NB DB schema version
    to determine if this is an old or a new OVN version.

    Change-Id: I8f3f0c2d516e37145eb298b8f51d92fe9905158a
    Closes-Bug: #2026825
    Signed-off-by: Lucas Alvares Gomes <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/892772

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/892773

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/892774

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/892775

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/892776

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892772
Committed: https://opendev.org/openstack/neutron/commit/cd6171a6eb8c9f08d0591d8b558f8d84b37e97ea
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit cd6171a6eb8c9f08d0591d8b558f8d84b37e97ea
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Jul 11 11:29:13 2023 +0100

    [OVN] Disable the mcast_flood_reports option for LSPs

    The mcast_flood_reports option was being enabled on LSPs as a workaround
    for a problem in core OVN. The issue in core OVN has been fixed and this
    workaround is now causing an increase in the number of actions on the
    table 38 of OVN (at the risk of hitting a size limit).

    This patch disables the mcast_flood_reports option on newer versions of
    OVN while keeping the backward compatibility with the old ones.

    Since the fix in core OVN does not expose any information to the CMS to
    tell us that the issue is fixed this patch uses the NB DB schema version
    to determine if this is an old or a new OVN version.

    Change-Id: I8f3f0c2d516e37145eb298b8f51d92fe9905158a
    Closes-Bug: #2026825
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 06dbc5227b9208887bab9bc6623098c80156f36d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892773
Committed: https://opendev.org/openstack/neutron/commit/7da91baa25c295e0fda9b4a0ffe84c99e60970cc
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 7da91baa25c295e0fda9b4a0ffe84c99e60970cc
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Jul 11 11:29:13 2023 +0100

    [OVN] Disable the mcast_flood_reports option for LSPs

    The mcast_flood_reports option was being enabled on LSPs as a workaround
    for a problem in core OVN. The issue in core OVN has been fixed and this
    workaround is now causing an increase in the number of actions on the
    table 38 of OVN (at the risk of hitting a size limit).

    This patch disables the mcast_flood_reports option on newer versions of
    OVN while keeping the backward compatibility with the old ones.

    Since the fix in core OVN does not expose any information to the CMS to
    tell us that the issue is fixed this patch uses the NB DB schema version
    to determine if this is an old or a new OVN version.

    Change-Id: I8f3f0c2d516e37145eb298b8f51d92fe9905158a
    Closes-Bug: #2026825
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 06dbc5227b9208887bab9bc6623098c80156f36d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892774
Committed: https://opendev.org/openstack/neutron/commit/334dc3322aebea32cb35ed4398aa191411c22ca4
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 334dc3322aebea32cb35ed4398aa191411c22ca4
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Jul 11 11:29:13 2023 +0100

    [OVN] Disable the mcast_flood_reports option for LSPs

    The mcast_flood_reports option was being enabled on LSPs as a workaround
    for a problem in core OVN. The issue in core OVN has been fixed and this
    workaround is now causing an increase in the number of actions on the
    table 38 of OVN (at the risk of hitting a size limit).

    This patch disables the mcast_flood_reports option on newer versions of
    OVN while keeping the backward compatibility with the old ones.

    Since the fix in core OVN does not expose any information to the CMS to
    tell us that the issue is fixed this patch uses the NB DB schema version
    to determine if this is an old or a new OVN version.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py

    Change-Id: I8f3f0c2d516e37145eb298b8f51d92fe9905158a
    Closes-Bug: #2026825
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 06dbc5227b9208887bab9bc6623098c80156f36d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892775
Committed: https://opendev.org/openstack/neutron/commit/fb5f8f2a2234329774ab50581197ea2b8dad1cfb
Submitter: "Zuul (22348)"
Branch: stable/xena

commit fb5f8f2a2234329774ab50581197ea2b8dad1cfb
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Jul 11 11:29:13 2023 +0100

    [OVN] Disable the mcast_flood_reports option for LSPs

    The mcast_flood_reports option was being enabled on LSPs as a workaround
    for a problem in core OVN. The issue in core OVN has been fixed and this
    workaround is now causing an increase in the number of actions on the
    table 38 of OVN (at the risk of hitting a size limit).

    This patch disables the mcast_flood_reports option on newer versions of
    OVN while keeping the backward compatibility with the old ones.

    Since the fix in core OVN does not expose any information to the CMS to
    tell us that the issue is fixed this patch uses the NB DB schema version
    to determine if this is an old or a new OVN version.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
      neutron/tests/unit/fake_resources.py

    Change-Id: I8f3f0c2d516e37145eb298b8f51d92fe9905158a
    Closes-Bug: #2026825
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 06dbc5227b9208887bab9bc6623098c80156f36d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892776
Committed: https://opendev.org/openstack/neutron/commit/a29996e2205c3b8c9b272b54d17525b983aefff4
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a29996e2205c3b8c9b272b54d17525b983aefff4
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Jul 11 11:29:13 2023 +0100

    [OVN] Disable the mcast_flood_reports option for LSPs

    The mcast_flood_reports option was being enabled on LSPs as a workaround
    for a problem in core OVN. The issue in core OVN has been fixed and this
    workaround is now causing an increase in the number of actions on the
    table 38 of OVN (at the risk of hitting a size limit).

    This patch disables the mcast_flood_reports option on newer versions of
    OVN while keeping the backward compatibility with the old ones.

    Since the fix in core OVN does not expose any information to the CMS to
    tell us that the issue is fixed this patch uses the NB DB schema version
    to determine if this is an old or a new OVN version.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
      neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
      neutron/tests/unit/fake_resources.py

    Note about this backport: I manually added the LSP_TYPE_LOCALPORT
    constant to this patch to simplify the backport

    Change-Id: I8f3f0c2d516e37145eb298b8f51d92fe9905158a
    Closes-Bug: #2026825
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 06dbc5227b9208887bab9bc6623098c80156f36d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron xena-eom release.