[neutron-api] remove leader_only for maintenance worker

[Maxim Korezkij]

Currently if you want to connect the neutron-api to the souhtbound database you cannot use relays, because the maintenance worker has a condition set that it requires a leader_only connection.

This leader_only collection is not necessary since the maintenance tasks of the neutron-api are only getting information from the souhtbound and are not pushing information into the souhtbound database.

If you adjust the neutron-api to use relays, it will log something like "relay database, cannot be leader" every time the maintenance task should run.

I would expect to be able to set the southbound connection for the neutron-api to use the relays.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Patch: https://review.opendev.org/c/openstack/neutron/+/885240

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/894783

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/894784

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/889807
Committed: https://opendev.org/openstack/neutron/commit/f0abced1c94665142100e2b53fa398ebad8e5f01
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit f0abced1c94665142100e2b53fa398ebad8e5f01
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/889817
Committed: https://opendev.org/openstack/neutron/commit/a34549294c13f6528399cd2b0af24b0be080c6e5
Submitter: "Zuul (22348)"
Branch: stable/zed

commit a34549294c13f6528399cd2b0af24b0be080c6e5
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/889804
Committed: https://opendev.org/openstack/neutron/commit/580027b7c9f12e005a93a3aae378c486f50cc642
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 580027b7c9f12e005a93a3aae378c486f50cc642
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894783
Committed: https://opendev.org/openstack/neutron/commit/067364fce50ca4105b3a98f9838d7fecc8e6baec
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 067364fce50ca4105b3a98f9838d7fecc8e6baec
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/894784
Committed: https://opendev.org/openstack/neutron/commit/9869029aef1dafca4637aaf43f587ce4799cade4
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9869029aef1dafca4637aaf43f587ce4799cade4
Author: maximkorezkij <email address hidden>
Date: Mon Jun 5 11:20:47 2023 +0200

    [neutron-api] remove leader_only for sb connection

    The maintenance worker from the neutron-api uses a southbound
    connection. Since the southbound does not use any locking and all the
    ovsdb locking is used for the northbound this changes should not have a
    big impact.

    This commit removes the leader_only flag for the maintenance worker.
    This should also enable the neutron api to connect to relays instead of only
    the sb directly.

    Closes-Bug: #2022914
    Change-Id: Ia7937390867e45af34ebcd65bd76fc89b6adafe9
    Signed-off-by: maximkorezkij <email address hidden>
    (cherry picked from commit a9c8bf5c069d3324828294e3e36b5374d5a828fe)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.2.0 release.

[Brian Haley (brian-haley)]

Patches have merged, will close.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron xena-eom release.