[OVN] Trunk can be deleted when the parent port is bound to a VM

[Rodolfo Alonso]

Inlike in other backends (ML2/OVS for example), the "Trunk" object can be deleted while the parent port (and the subports) are bound. This operation should raise an exception instead (same as in ML2/OVS).

Example using ML2/OVS:
$ openstack network trunk delete trunk1
Failed to delete trunk with name or ID 'trunk1': ConflictException: 409: Client Error for url: http://192.168.10.70:9696/networking/v2.0/trunks/c406114f-8453-4b55-8642-c9265defdec4, Trunk c406114f-8453-4b55-8642-c9265defdec4 is currently in use.
1 of 1 trunks failed to delete.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/885154

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/887603
Committed: https://opendev.org/openstack/neutron/commit/539961b4b9563588d3fe51c84b062b153d97ce68
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 539961b4b9563588d3fe51c84b062b153d97ce68
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue May 30 11:45:37 2023 +0200

    [OVN] Prevent Trunk creation/deletion with parent port bound

    This patch imitates the ML2/OVS Trunk driver behaviour. When the
    trunk parent port is bound:
    * A new trunk cannot be created using this parent port.
    * If the port is assigned as parent port of a trunk, this
      trunk cannot be deleted.

    Conflicts:
        neutron/db/l3_dvr_db.py
        neutron/common/utils.py

    Closes-Bug: #2022059
    Change-Id: I8cfa7e67524a42224cbb4b3c3cec3cfa49b795fd
    (cherry picked from commit 833a6d82cd705548130cdac73a88d388f52c7824)
    (cherry picked from commit 2f48c24d412ee07d7cc609cf8379de83380324e3)
    (cherry picked from commit 0d499808f1f3ec6cf40bb87eb32789c463401338)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/887606
Committed: https://opendev.org/openstack/neutron/commit/e7bbad059199e8ef1d1dcc32070e273fd06d08b7
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit e7bbad059199e8ef1d1dcc32070e273fd06d08b7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue May 30 11:45:37 2023 +0200

    [OVN] Prevent Trunk creation/deletion with parent port bound

    This patch imitates the ML2/OVS Trunk driver behaviour. When the
    trunk parent port is bound:
    * A new trunk cannot be created using this parent port.
    * If the port is assigned as parent port of a trunk, this
      trunk cannot be deleted.

    Conflicts:
        neutron/db/l3_dvr_db.py
        neutron/common/utils.py
        neutron/services/trunk/drivers/ovn/trunk_driver.py
        neutron/services/trunk/plugin.py
        neutron/tests/unit/db/test_l3_dvr_db.py
        neutron/tests/unit/services/trunk/test_plugin.py

    Closes-Bug: #2022059
    Change-Id: I8cfa7e67524a42224cbb4b3c3cec3cfa49b795fd
    (cherry picked from commit 833a6d82cd705548130cdac73a88d388f52c7824)
    (cherry picked from commit 2f48c24d412ee07d7cc609cf8379de83380324e3)
    (cherry picked from commit 0d499808f1f3ec6cf40bb87eb32789c463401338)
    (cherry picked from commit 539961b4b9563588d3fe51c84b062b153d97ce68)
    (cherry picked from commit 0026b75babc4e8b873763c7aa9340ad10cc51192)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron xena-eom release.