Running neutron under wsgi should not register signals

Bug #2021814 reported by Arnaud Morin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Arnaud Morin

Bug Description

When running neutron behing apache mod_wsgi, neutron should not register any signal.

The signals are ignored by mod_wsgi but some traceback are printed in logs:

in plugins/ml2/ovo_rpc.py

signal.signal(signal.SIGINT, _ObjectChangeHandler.clean_up)
mod_wsgi (pid=10202): Callback registration for signal 15 ignored.

Also, when enabling Guru Meditation Reports, neutron is not able to take oslo_reports parameters into account.
See:
https://github.com/openstack/neutron/blob/master/neutron/cmd/__init__.py
https://github.com/openstack/oslo.reports/blob/master/oslo_reports/guru_meditation_report.py

Changed in neutron:
assignee: nobody → Arnaud Morin (arnaud-morin)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/884711

Miro Tomaska (mtomaska)
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/884842

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/884711
Committed: https://opendev.org/openstack/neutron/commit/878ea0dfd5e0af358b3d0bbd3a7888b55569d7cf
Submitter: "Zuul (22348)"
Branch: master

commit 878ea0dfd5e0af358b3d0bbd3a7888b55569d7cf
Author: Arnaud Morin <email address hidden>
Date: Tue May 30 16:48:32 2023 +0200

    Add a new option to enable signals

    When running behind a wsgi server like apache/mod_wsgi, neutron should
    not register on Signals, it will overlap with the Signals registered by
    the wsgi server.

    Related-Bug: #2021814

    Change-Id: I3c74846a8337d019f1ab6759ebb03f18c3f00238
    Signed-off-by: Arnaud Morin <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/884842
Committed: https://opendev.org/openstack/neutron/commit/56821b6aea6be073352094ee32ae22fae5d6de01
Submitter: "Zuul (22348)"
Branch: master

commit 56821b6aea6be073352094ee32ae22fae5d6de01
Author: Arnaud Morin <email address hidden>
Date: Tue May 30 16:54:28 2023 +0200

    Register GMR with config

    As an operator, we want to set oslo_reports/file_event_handler because
    when running behind a wsgi server, GMR cannot register the Signal to be
    trigger.
    The parameter file_event_handler has been designed for this specific use
    case but it was not used correctly by neutron.

    Closes-Bug: #2021814

    Change-Id: Id13de1a3f9ea2eaaa7521eedf905aa0dd993ff89
    Signed-off-by: Arnaud Morin <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 24.0.0.0b1

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.