[OVN] - Logging configuration doesn't change after neutron restart

[Elvira García Ruiz]

Right now adding a new rate and burst limit to the network_log configuration in the ml2_conf.ini file won't make any effect on the system as OVN meter-band will remain unchanged. To make it work you need to remove every logging object (so that the meter entry in OVN is removed) and then recreate them again. This is not how it should work.

100% reproducible

Steps:
- Add log plugin
- Add log object to the project
- change rate and burst limit
- restart the neutron server to see if changes applied

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/880982

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/880982
Committed: https://opendev.org/openstack/neutron/commit/c3602ac19b62b77d3cb763746e124881d4c061e4
Submitter: "Zuul (22348)"
Branch: master

commit c3602ac19b62b77d3cb763746e124881d4c061e4
Author: Elvira García <email address hidden>
Date: Thu Apr 20 16:39:12 2023 +0200

    [OVN] Update ovn meter when neutron server reloads

    Up until now, we needed to remove all logging objects to see the
    meter-band properties being changed after a server restart. Now we check
    for inconsistencies between the neutron configuration and the OVN
    meter-band object after a restart. The function create_ovn_fair_meter is
    now located in the ovn_driver instead of the log_driver so as to be able
    to call it from the maintenance task.

    Closes-bug: #2017145
    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I24cef85ed68c893a740445707f88296d763c8de8

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/882519

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/882689

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/882527

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/882711

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/882809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/882519
Committed: https://opendev.org/openstack/neutron/commit/05ff8ce3eeecbd981258864d324d3b011489df20
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 05ff8ce3eeecbd981258864d324d3b011489df20
Author: Elvira García <email address hidden>
Date: Thu Apr 20 16:39:12 2023 +0200

    [OVN] Update ovn meter when neutron server reloads

    Up until now, we needed to remove all logging objects to see the
    meter-band properties being changed after a server restart. Now we check
    for inconsistencies between the neutron configuration and the OVN
    meter-band object after a restart. The function create_ovn_fair_meter is
    now located in the ovn_driver instead of the log_driver so as to be able
    to call it from the maintenance task.

    Closes-bug: #2017145
    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I24cef85ed68c893a740445707f88296d763c8de8
    (cherry picked from commit c3602ac19b62b77d3cb763746e124881d4c061e4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/882527
Committed: https://opendev.org/openstack/neutron/commit/46aefebd5dc9c8524fdffba889b4e6b364e4f2dd
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 46aefebd5dc9c8524fdffba889b4e6b364e4f2dd
Author: Elvira García <email address hidden>
Date: Thu Apr 20 16:39:12 2023 +0200

    [OVN] Update ovn meter when neutron server reloads

    Up until now, we needed to remove all logging objects to see the
    meter-band properties being changed after a server restart. Now we check
    for inconsistencies between the neutron configuration and the OVN
    meter-band object after a restart. The function create_ovn_fair_meter is
    now located in the ovn_driver instead of the log_driver so as to be able
    to call it from the maintenance task.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_client.py

    Closes-bug: #2017145
    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I24cef85ed68c893a740445707f88296d763c8de8
    (cherry picked from commit c3602ac19b62b77d3cb763746e124881d4c061e4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/882689
Committed: https://opendev.org/openstack/neutron/commit/1864dd868459384e8f19ba413929a8c196877370
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 1864dd868459384e8f19ba413929a8c196877370
Author: Elvira García <email address hidden>
Date: Thu Apr 20 16:39:12 2023 +0200

    [OVN] Update ovn meter when neutron server reloads

    Up until now, we needed to remove all logging objects to see the
    meter-band properties being changed after a server restart. Now we check
    for inconsistencies between the neutron configuration and the OVN
    meter-band object after a restart. The function create_ovn_fair_meter is
    now located in the ovn_driver instead of the log_driver so as to be able
    to call it from the maintenance task.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_client.py

    Closes-bug: #2017145
    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I24cef85ed68c893a740445707f88296d763c8de8
    (cherry picked from commit c3602ac19b62b77d3cb763746e124881d4c061e4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/882809
Committed: https://opendev.org/openstack/neutron/commit/43ee9f3a9474f382fba9db063722d1c0dfee9b48
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 43ee9f3a9474f382fba9db063722d1c0dfee9b48
Author: Elvira García <email address hidden>
Date: Thu Apr 20 16:39:12 2023 +0200

    [OVN] Update ovn meter when neutron server reloads

    Up until now, we needed to remove all logging objects to see the
    meter-band properties being changed after a server restart. Now we check
    for inconsistencies between the neutron configuration and the OVN
    meter-band object after a restart. The function create_ovn_fair_meter is
    now located in the ovn_driver instead of the log_driver so as to be able
    to call it from the maintenance task.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_client.py
        neutron/services/logapi/drivers/ovn/driver.py

    Closes-bug: #2017145
    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I24cef85ed68c893a740445707f88296d763c8de8
    (cherry picked from commit c3602ac19b62b77d3cb763746e124881d4c061e4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/882711
Committed: https://opendev.org/openstack/neutron/commit/da43b03eb224249490d862cae6cec3962e4481a4
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit da43b03eb224249490d862cae6cec3962e4481a4
Author: Elvira García <email address hidden>
Date: Thu Apr 20 16:39:12 2023 +0200

    [OVN] Update ovn meter when neutron server reloads

    Up until now, we needed to remove all logging objects to see the
    meter-band properties being changed after a server restart. Now we check
    for inconsistencies between the neutron configuration and the OVN
    meter-band object after a restart. The function create_ovn_fair_meter is
    now located in the ovn_driver instead of the log_driver so as to be able
    to call it from the maintenance task.

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_client.py
        neutron/services/logapi/drivers/ovn/driver.py

    Closes-bug: #2017145
    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I24cef85ed68c893a740445707f88296d763c8de8
    (cherry picked from commit c3602ac19b62b77d3cb763746e124881d4c061e4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron xena-eom release.